Repository navigation
Android: one ABI per release APK - #105
Merged
Merged
Conversation
Both release APKs carried arm64-v8a and x86_64 (v0.3.20: 70982410 bytes each, 257 libraries per ABI in each). The csproj lists RuntimeIdentifiers=android-arm64;android-x64, and .NET Android packs every listed RID into the APK whatever -r says. Each publish step now also passes -p:RuntimeIdentifiers=<rid>, so the arm64 APK holds only arm64-v8a and the x64 one only x86_64: 36.7 MB and 38.1 MB locally instead of 71 MB. The verify step now fails the job if an APK holds any other ABI; run against the v0.3.20 APKs it stops at "arm64 APK ABIs: arm64-v8a x86_64". Fixes #101
PR Summary by QodoPackage one Android ABI per release APK
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each publish step now passes
-p:RuntimeIdentifiers=<rid>: the csproj lists both RIDs and .NET Android packs every listed one regardless of-r, so both v0.3.20 APKs held arm64-v8a and x86_64 (70982410 bytes each). Now 36.7 MB (arm64) and 38.1 MB (x64). The verify step also fails the job if an APK holds another ABI (on the v0.3.20 APKs it stops witharm64 APK ABIs: arm64-v8a x86_64). The x64 APK runs on an Android TV 16 emulator.Fixes #101