Repository navigation
CI: build and test every desktop project (Analytics, Infrastructure, Web) - #104
Merged
Merged
Conversation
…Web) OpenIPC.Viewer.Desktop.slnx, which the desktop CI job restores, builds and tests, was added as "the full solution minus the two mobile heads", but the projects added to OpenIPC.Viewer.slnx since then never made it in: src/Analytics, src/Web and the Analytics, Infrastructure and Web test projects. CI never ran those 83 tests. Add them, in the full solution's order. Infrastructure.Tests goes in as a plain entry: the full solution excludes it from Debug builds, and since restore runs in Debug, carrying that over would leave it unrestored and fail the Release build (NETSDK1004). Locally, as in CI (Release, /warnaserror): 0 warnings; 610 tests passed, 9 skipped, in 6 test projects. Fixes #100
PR Summary by QodoInclude missing projects in desktop CI builds and tests
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenIPC.Viewer.Desktop.slnx(what the desktop job restores, builds and tests) was meant to be the full solution minus the mobile heads, butsrc/Analytics,src/Weband the Analytics, Infrastructure and Web test projects were never added, so CI never ran those 83 tests. This adds them in the full solution's order.Infrastructure.Testsgoes in without the<Build Solution="Debug|*" Project="false" />it has inOpenIPC.Viewer.slnx: restore runs in Debug, so carrying it over leaves the project unrestored and fails the Release build (NETSDK1004). That exclusion came in with 47c8761 (analytics) — @keyldev, is it intended there? If not, it can go from the full solution too.Locally, as in CI: Release
/warnaserror, 0 warnings; 610 passed, 9 skipped in 6 test projects.Fixes #100