[19.0][FIX] base_comment_template: comment_template_ids domain#1167
Open
Qlasta wants to merge 1 commit into
Open
[19.0][FIX] base_comment_template: comment_template_ids domain#1167Qlasta wants to merge 1 commit into
Qlasta wants to merge 1 commit into
Conversation
The field filtered candidates by comparing the computed, non-stored
relational field against a model name string:
domain=lambda self: [(model_ids, in, self._name)]
The 19.0 domain engine () rewrites a relational-vs-
scalar leaf into the operator with a sub-domain on the comodel:
(model_ids, any, [(display_name, in, [account.asset])])
Build the domain from instead.
OCA-git-bot
added
series:19.0
mod:base_comment_template
HviorForgeFlow
approved these changes
Jun 11, 2026
Contributor
|
This PR has the |
pedrobaeza
reviewed
Jun 25, 2026
Comment on lines
+29
to
+31
| domain=lambda self: self.env["base.comment.template"]._search_model_ids( | ||
| "in", self._name | ||
| ), |
Member
There was a problem hiding this comment.
Shouldn't it be just?:
Suggested change
| domain=lambda self: self.env["base.comment.template"]._search_model_ids( | |
| "in", self._name | |
| ), | |
| domain=lambda self: [("model_ids", "=", self._name)], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The field filtered candidates by comparing the computed, non-stored relational field against a model name string:
The 19.0 domain engine (odoo.fields.Domain) rewrites a relational-vs- scalar leaf into the operator with a sub-domain on the comodel:
Build the domain from _search_model_ids instead.