feat: adds reusable actions#296
Conversation
|
I like the general direction. |
|
Feedback from the meeting from both @lornajane and @ralfhandl :
|
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
e709bde to
06a21c9
Compare
ralfhandl
left a comment
There was a problem hiding this comment.
Mostly wording and capitalization
Co-authored-by: Ralf Handl <ralf.handl@gmail.com>
Co-authored-by: Ralf Handl <ralf.handl@gmail.com>
Co-authored-by: Ralf Handl <ralf.handl@gmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
…rlay-Specification into feat/action-templates Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
|
@ralfhandl @lornajane I pushed another update a couple of minutes ago. I wasn't happy about the whole reusable actions vs action templates kind of thing. After chatting with @mikekistler internally I realized we could simply define a an action template reference object as "you can override anything from the resolved template in the reference" like JSON schema does to some extent. And keep things extra simple. Let me know what you think! |
…ferences Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
mikekistler
left a comment
There was a problem hiding this comment.
Looks good. 👍
I made some suggestions that I think are improvements, but will leave the decision to you . Feel free to ignore these if you think they are off the mark.
mikekistler
left a comment
There was a problem hiding this comment.
Sorry ... that should have been a Approve.
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Ralf Handl <ralf.handl@gmail.com>
lornajane
left a comment
There was a problem hiding this comment.
Had a more detailed pass at it this time, added a few comments for things we should take a second glance at (especially considering how much refactoring has been done on this one) but nothing fundamental I promise!
There was a problem hiding this comment.
We might want to update the Overlay section in Definitions to make it a bit less specific? Right now it says
An Overlay is a JSON or YAML structure containing an ordered list of Action Objects that are to be applied to the target document.
There was a problem hiding this comment.
attempted an update via a8c1719
Happy to take better suggestions.
| 1. A Reusable Action Object has to be referenced by a Reusable Action Reference Object to have any effect on the OpenAPI description. | ||
|
|
||
| #### Reusable Action Reference Object | ||
|
|
There was a problem hiding this comment.
Let's add a sentence or two about what a resusable action reference object is and what it's for before we describe its fields
| @@ -0,0 +1,10 @@ | |||
| overlay: 1.2.0 | |||
| info: | |||
| title: Reusable action with empty fields | |||
There was a problem hiding this comment.
I don't think I understand this one (and therefore probably didn't understand an earlier case that I also commented on!). How can an action have empty fields and succeed? Also should the one action in the collection here include a $ref ?
There was a problem hiding this comment.
Here we're simply testing the JSON schema. This tests that:
- fields is required on the reusable action object
- any field under fields is not required (because we use the same base schema as the actions, and that was not required, and requiring it now would be breaking)
Let me know if you have any additional comments or questions.
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
|
@lornajane thanks for the great suggestions here! I took the liberty of resolving the ones that I considered trivial. Let me know what you think! |
This pull request adds reusable actions.
closes #238
Reusable actions are a much simpler iteration of anything previously proposed/iterated on:
This iteration is better than earlier proposals because it's as simple as we can possibly make it. (no matrix, no variables, no string interpolation, etc...)