Skip to content

Aggressive patchFlatListProps #12

Open
Open
Aggressive patchFlatListProps#12

Description

@yangm97
yangm97
opened on Sep 11, 2021

When props.refreshing is undefined refreshControl shouldn't be be injected.

Right now patchFlatListProps changes the behavior of FlatLists which aren't supposed to have a refreshControl. It also causes some type warnings to be thrown in development.

https://snack.expo.dev/wcIw8L47u

Activity

  1. yangm97 commented on Sep 11, 2021

    @yangm97
    yangm97
    on Sep 11, 2021
    Author

    Also breaks horizontal FlatLists https://snack.expo.dev/x_4Fv3WDC

  2. NiciusB commented on Sep 11, 2021

    @NiciusB
    NiciusB
    on Sep 11, 2021
    Owner

    You're right. I will fix it ASAP. It should only inject when onRefresh is defined, as per the FlatList docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions