fix(intanrawio): one-file-per-signal digital streams are packed in one word per sample#1854
fix(intanrawio): one-file-per-signal digital streams are packed in one word per sample#1854SAY-5 wants to merge 1 commit into
Conversation
…e word per sample
|
Hi, do you have test data that you can share with us so we can stub it and add is a regression? |
|
I don't have hardware data to share; I worked from the Intan one-file-per-signal docs and existing memmap test shapes, so the unit test in this PR asserts the demultiplex shape contract rather than driving a real recording. Happy to coordinate if any maintainer can share a small two-or-more-DIN one-file-per-signal capture and we can fold it into the existing intan test fixtures. |
|
I don't have the original capture from #1853, but the existing one-file-per-signal fixture ( |
h-mayorquin
left a comment
There was a problem hiding this comment.
Ok, thanks. This is good but we are pending on testing data.
I asked Charlie in the issue if he might be able to share some with us if the data is stubbed. Otherwise, I might have one in a week or two. This can wait a bit unless some user wants to jump in and provide example data to expedite this. If not, we will merge for sure before the release.
Fixes #1853. For
one-file-per-signalIntan recordings the digital input/output.datfile holds one packed 16-bit word per timestamp regardless of how many digital channels are enabled, but the memmap layer divided the file size by the channel count and reported half the true sample length, which then crashed_demultiplex_digital_datawith a broadcast shape mismatch when more than one digital channel was active. The fix treats the digital streams as single-column files and adds a small unit test covering the demultiplex shape contract.