Integrating ALTQ in NPF - #42
Open
Emmankoko wants to merge 10000 commits into
Open
Conversation
PR toolchain/58960: Missing support for _NETBSD_REVISIONID on various ports
This was assigned before the function was called.
This also works for machines with FPU. If the kernel defines FPU_EMULATE, even illegal FPU instructions in the real 6888x machines, the FPE will be executed by F line exception. So the FPE must raise SIGILL appropriately for these.
Use DIOCGMEDIASSIZE ioctl when no partition info is available to generate st_size information. This helps dk(4) and dm(4) devices.
id string as well as _NETBSD_REVISIONID. Do not rely on string concatenation in the inline assembler, use .ascii and .asciz for individual string parts instead.
…et source and destination buffer independently
There are many places where 'long' is narrowed to 'int', so if these had serious problems, these would have probably been found earlier. Suppress these warnings to make the remaining ones more visible, as these may point to more interesting places in the code.
Previously, indent assumed that no 'else' would follow.
Should fix PR 57821.
explanatory comments.
Emmankoko
force-pushed
the
npf_altq
branch
7 times, most recently
from
February 4, 2025 13:26
c7d1744 to
e06168a
Compare
altq communicate to pf through pf_altq queue structures. similar is done for npf and being used to replace pf's pf_altq. npf_altq fileds are compatible with struct pf_altq as they represent a complete queue structure. a needs-flag is set on npf to produce a npf.h during config in the kernel directory which will set optional compilation for npf related code in altq. it is also handled at runtime in the npf module.
includes the queue structure field and a trace of the number of queues being loaded into the kernel and make npf_altq available in include directory for use in altq framework
it is implemented to compute all params of queues for any kind of scheduler
checks: first checks if the queue obeys best practices(having a default queue etc) checks if the referenced queue is defined in the queues then sets the queue to queue nvpair in the rules nvlist.
Emmankoko
force-pushed
the
npf_altq
branch
2 times, most recently
from
February 5, 2025 17:57
fc2accf to
470a691
Compare
starting ALTQ is fully handed over to the kernel. when you start NPF, it checks if altq is loaded and not already running. if ALTQ is already running, it ignores it.
altq is disabled when you stop npf. it is handled internally in kerneland checks if altq is running. in npf, no filtering no queueing so why should queueing be active whiles filtering is disabled?
netbsd-srcmastr
pushed a commit
that referenced
this pull request
Oct 1, 2025
external/gpl2/texinfo/dist/info/display.c: revision 1.2 info(1): fix ctype(3) usage to avoid coredump
netbsd-srcmastr
force-pushed
the
trunk
branch
from
January 19, 2026 00:15
bd68c70 to
d8e8e07
Compare
netbsd-srcmastr
pushed a commit
that referenced
this pull request
Jul 26, 2026
external/gpl2/texinfo/dist/info/display.c: revision 1.2 info(1): fix ctype(3) usage to avoid coredump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
altq communicate to pf through pf_altq queue structures. similar is done for npf and being used to replace pf's pf_altq. npf_altq fileds are compatible with struct pf_altq as they represent a complete queue structure.
a needs-flag is set on npf to produce a npf.h during config in the kernel directory which will set optional compilation for npf related code in altq. it is also handled at runtime in the npf module.
@zoulasc @MartinHusemann