Mesh: standardize tensor-valued gradient layout - #1772
Merged
peterdsharpe merged 2 commits intoJul 9, 2026
Merged
Conversation
Collaborator
Author
|
/ok to test 815743a |
peterdsharpe
marked this pull request as ready for review
July 1, 2026 20:45
Contributor
Greptile SummaryThis PR standardizes tensor-valued gradient output across all PhysicsNeMo Mesh calculus paths (point/cell LSQ, intrinsic LSQ, and DEC) to the derivative-first layout
Important Files Changed
Reviews (1): Last reviewed commit: "fix(mesh): standardize calculus gradient..." | Re-trigger Greptile |
Collaborator
Author
|
/ok to test ae5e985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Previously, tensor-valued LSQ gradients moved the derivative-coordinate axis to the end, while the documented API, the functional LSQ implementation, and DEC use the derivative-first layout. This made the result depend on the gradient implementation and made vector-field Jacobians easy to misinterpret.
This PR standardizes tensor-valued gradients on
(entity, n_spatial_dims, *value_shape):gradient[i, k, j] = ∂v_j/∂x_kfor point and cell LSQ gradients.This is an intentional compatibility change for tensor-valued LSQ gradients. Scalar gradients are unchanged. A stored legacy tensor gradient can be converted with
legacy_gradient.movedim(-1, 1).Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.