Skip to content

ci(release): stop publishing Helm charts from the GitHub tag workflow - #2415

Open
rohithb-hub wants to merge 4 commits into
mainfrom
ci/retire-github-chart-publishing
Open

rohithb-hub wants to merge 4 commits into
mainfrom
ci/retire-github-chart-publishing

Conversation

@rohithb-hub

@rohithb-hub rohithb-hub commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR

Stop the GitHub tag workflow from publishing Helm charts, and bump the
helm-nvca-operator appVersion to 3.16.1.

Additional Details

  • Retire GitHub chart publishing: chart publishing is kept in the internal
    release pipeline, which already publishes every chart release. Chart tags
    and GitHub Releases are unchanged. For a chart tag, the tag job now only
    checks the chart name and creates the Release.
  • Bump appVersion: it has stayed at 3.12.7 for some time, so installs that do
    not set image.tag run operator 3.12.7. This moves it to 3.16.1; the
    images exist.

What changed:

  • tools/ci/github-release and release-tags.yml: removed chart packaging,
    registry login, push, the appVersion stamp, and the release_tag replay
    input.
  • Tests and release docs updated to match.
  • deploy/helm/nvca-operator/nvca-operator/Chart.yaml: appVersion 3.12.7 to
    3.16.1.

Follow-up: the chart version bumper that keeps appVersion current is stuck
and will be fixed separately.

Dependencies: none.

For the Reviewer

  • tools/ci/github-release: the chart block in tag_release.
  • .github/workflows/release-tags.yml: the tag job conditions.

For QA

  • python3 tools/ci/test-github-release.py: 116 tests pass.
  • Helm chart checks pass with Helm 3.21.4 (tools/ci/check-helm-charts and
    the nvca-operator chart tests).
  • QA not needed.

Issues

Closes #2218

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: rohithb <rohithb@nvidia.com>
@rohithb-hub
rohithb-hub requested review from a team as code owners October 9, 2026 11:58
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/nvcf/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 3f8b9903-3be8-4b43-8fde-02e7d3fdeed7
📥 Commits

Reviewing files that changed from the base of the PR and between ae10cf8 and 821a3f5.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/nvcf/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 44ba36c4-b256-45f9-b879-93d0b7e2da3f
📥 Commits

Reviewing files that changed from the base of the PR and between be9cff1 and acc101d.

📒 Files selected for processing (6)
  • .github/workflows/release-tags.yml
  • ai-tooling/dev/skills/nvca-values-customization/SKILL.md
  • deploy/helm/nvca-operator/nvca-operator/Chart.yaml
  • docs/dev/github-release-process.md
  • tools/ci/github-release
  • tools/ci/test-github-release.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

The release workflow removes manual replay of existing tags and chart publishing. Tag validation now uses the current ref and checks chart metadata. The chart’s appVersion and release-process documentation were updated.

Changes: Release Flow

Layer / File(s) Summary
Tag workflow and validation
.github/workflows/release-tags.yml, tools/ci/github-release, tools/ci/test-github-release.py
The workflow removes the replay input and runs tag release handling for tag refs. Release validation uses github.ref_name. The release script validates chart registration and the Chart.yaml release name. Tests cover tag handling and exclude the retired replay path.
Chart publishing boundary and metadata
tools/ci/github-release, tools/ci/test-github-release.py, deploy/helm/nvca-operator/nvca-operator/Chart.yaml, ai-tooling/dev/skills/nvca-values-customization/SKILL.md, docs/dev/github-release-process.md
The release script removes chart packaging and registry publication helpers. The chart appVersion changes to 3.16.1. The skill and release-process documentation describe committed appVersion values and chart publishing after release publication and mirroring. Follower-release wording and related test coverage were also updated or removed.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to acc10

The release-flow change is mergeable on the available evidence. The downstream chart publisher and availability of the new default image tag should be confirmed during release validation.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check Warning #2218 requires the publisher to treat the readable-repository not found result as absence and to stop on registry refusals. This PR removes the tag workflow's package, pull, comparison, and push pat… Implement and test the equivalent behavior in the chart release pipeline. A typed Helm not-found result must allow publication. Other registry read failures must stop publication. Keep coverage for both cases.
✅ Passed checks (4 passed)
Check name Status Explanation
Out of Scope Changes check Passed The workflow, release-tool, test, and documentation changes support the stated chart-publisher change. The committed appVersion bump supports the new pipeline because it packages the committed `Char…
Docstring Coverage Passed Docstring coverage is 82.35% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 1 files. (5 skipped: 5 …
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title uses valid Conventional Commits syntax with the allowed ci type and release scope. It accurately describes the primary change: stopping Helm chart publication from the GitHub tag workflow.
Full details: Linked Issues check

Explanation

#2218 requires the publisher to treat the readable-repository not found result as absence and to stop on registry refusals. This PR removes the tag workflow's package, pull, comparison, and push path, including its only repository refuse-to-replace check. The reviewed changes do not modify or establish equivalent behavior in the post-mirror chart pipeline. The new tests verify that the removed workflow does not publish, not the #2218 absence/refusal distinction.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chart publication fails for every new version: the absence check does not match the registry's reply

1 participant