Repository navigation
ci(release): stop publishing Helm charts from the GitHub tag workflow - #2415
Open
rohithb-hub wants to merge 4 commits into
Open
rohithb-hub wants to merge 4 commits into
rohithb-hub wants to merge 4 commits into
Conversation
Signed-off-by: rohithb <rohithb@nvidia.com>
Signed-off-by: rohithb <rohithb@nvidia.com>
Contributor
|
🌿 Preview your docs: https://nvidia-preview-ci-retire-github-chart-publishing.docs.buildwithfern.com/nvcf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Stop the GitHub tag workflow from publishing Helm charts, and bump the
helm-nvca-operatorappVersion to 3.16.1.Additional Details
release pipeline, which already publishes every chart release. Chart tags
and GitHub Releases are unchanged. For a chart tag, the tag job now only
checks the chart name and creates the Release.
not set
image.tagrun operator 3.12.7. This moves it to 3.16.1; theimages exist.
What changed:
tools/ci/github-releaseandrelease-tags.yml: removed chart packaging,registry login, push, the appVersion stamp, and the
release_tagreplayinput.
deploy/helm/nvca-operator/nvca-operator/Chart.yaml: appVersion 3.12.7 to3.16.1.
Follow-up: the chart version bumper that keeps appVersion current is stuck
and will be fixed separately.
Dependencies: none.
For the Reviewer
tools/ci/github-release: the chart block intag_release..github/workflows/release-tags.yml: the tag job conditions.For QA
python3 tools/ci/test-github-release.py: 116 tests pass.tools/ci/check-helm-chartsandthe nvca-operator chart tests).
Issues
Closes #2218
Checklist