Skip to content

preingestion: power off host before BMC firmware update#2582

Closed
williampnvidia wants to merge 1 commit into
NVIDIA:mainfrom
williampnvidia:william/preingestion-fw-power-off
Closed

preingestion: power off host before BMC firmware update#2582
williampnvidia wants to merge 1 commit into
NVIDIA:mainfrom
williampnvidia:william/preingestion-fw-power-off

Conversation

@williampnvidia

Copy link
Copy Markdown
Contributor

Summary

  • add preingestion_power_off_host_before_update firmware-entry flag
  • power off host immediately before preingestion host BMC firmware updates when the flag is set
  • ignore the flag for DPU/BlueField endpoints because DPU must remain powered for firmware update
  • cover host-BMC power-off behavior and LenovoAMI firmware-config fallback in tests

Deployment note

This PR does not add a new checked-in Lenovo HS350 firmware entry. To enable this for the Lenovo HS350 / HS350X V3 runtime config that already performs the BMC firmware update, set this on the existing BMC known_firmware entry:

preingestion_power_off_host_before_update = true

The LenovoAMI fallback test verifies that an endpoint reporting LenovoAMI can still match the Lenovo HS350 firmware metadata carrying this flag.

Testing

  • cargo check -q -p carbide-preingestion-manager
  • cargo test -q -p carbide-firmware lenovoami -- --nocapture
  • cargo test -q -p carbide-api-core --no-default-features power_off_before_update --no-run
  • cargo fmt

@copy-pr-bot

copy-pr-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7ed26782-3042-4ae2-9881-d460957f75fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@williampnvidia

Copy link
Copy Markdown
Contributor Author

This is no longer needed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant