Fix concurrent clique table publication - #1775
Draft
derluke wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Lukas Innig <lukas.innig@gmail.com>
akifcorduk
added
bug
akifcorduk
requested changes
Aug 26, 2026
akifcorduk
left a comment
akifcorduk
left a comment
Contributor
There was a problem hiding this comment.
I was not able to reproduce it locally, but this is indeed a potential race. Could you remove the tests?
| handle_.sync_stream(); | ||
|
|
||
| constexpr int num_solves = 25; | ||
| for (int solve = 0; solve < num_solves; ++solve) { |
Contributor
There was a problem hiding this comment.
These tests are prohibitive for the CI. Could you remove this test completely?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1774.
shared_ptr.Pre-commit passes. The C++ regression requires the cuOpt build environment and MIP datasets, so it is left for CI.