cuda.core: fix some type signatures that are too generic - #2670
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
juenglin
added
cuda.core
juenglin
commented
Aug 18, 2026
Contributor
Author
There was a problem hiding this comment.
Using StreamOptions has become necessary with this change because StreamOptions is a "cdef dataclass".
See related discussion in PR #2634.
Contributor
Author
|
/ok to test 4a7cd59 |
This comment has been minimized.
This comment has been minimized.
juenglin
marked this pull request as ready for review
August 18, 2026 23:28
juenglin
enabled auto-merge (squash)
August 19, 2026 02:14
juenglin
force-pushed
the
options-typing
branch
from
August 20, 2026 16:03
4a7cd59 to
ce3d342
Compare
Contributor
juenglin
force-pushed
the
options-typing
branch
from
August 20, 2026 16:04
ce3d342 to
d179d6b
Compare
juenglin
force-pushed
the
options-typing
branch
from
August 20, 2026 16:08
d179d6b to
c34bdbb
Compare
Contributor
Author
|
/ok to test c34bdbb |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
optionsparameter type annotations that were typed asobjectinstead of their proper options types (StreamOptions,TensorMapDescriptorOptions).