Skip to content

ci: run released cuda-core compat on bindings PRs (#2449) - #2638

Open
atiaomar1978-hub wants to merge 3 commits into
NVIDIA:mainfrom
atiaomar1978-hub:ci/pr-nightly-cuda-core-2449
Open

ci: run released cuda-core compat on bindings PRs (#2449)#2638
atiaomar1978-hub wants to merge 3 commits into
NVIDIA:mainfrom
atiaomar1978-hub:ci/pr-nightly-cuda-core-2449

Conversation

@atiaomar1978-hub

Copy link
Copy Markdown
Contributor

Summary

  • Adds test-cuda-core-linux-64 to PR CI (ci.yml), reusing the existing nightly-cuda-core test mode from CI: nightly-cuda-core + nightly-numba-cuda-mlir + PTDS fix #2283
  • Runs when detect-changes flags bindings-related path changes (cuda_bindings, cuda_pathfinder, shared infra, test helpers)
  • Uses PR-built pathfinder/bindings wheels from the current run + released cuda-core from PyPI, then executes the released tag's test suite
  • Updates the checks aggregator with conditional expectations (success when bindings change, skipped otherwise)
  • Adds guardrail unit tests in ci/tools/tests/test_ci_pr_cuda_core_compat.py

Fixes #2449

Test plan

  • pytest -v --noconftest ci/tools/tests/test_ci_pr_cuda_core_compat.py (6 passed locally)
  • Upstream CI: verify test-cuda-core-linux-64 runs on this PR (touches .github/workflows/ci.yml → shared infra → test_bindings=true)
  • Upstream CI: verify checks aggregator passes with the new conditional gate

Made with Cursor

Wire the existing nightly-cuda-core test mode into PR CI when
cuda_bindings or related paths change, and add guardrail tests so the
workflow wiring stays aligned with the nightly jobs.

Signed-off-by: Omar Atie <atiaomar1978@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Aug 14, 2026
nightly-cuda-core still needs PR-built pathfinder/bindings wheels;
only disable standard cuda-core and meta-package pytest runs.

Signed-off-by: Omar Atie <atiaomar1978@gmail.com>
Apply ruff format to test_ci_pr_cuda_core_compat.py for pre-commit.ci.

Signed-off-by: Omar Atie <atiaomar1978@gmail.com>
@atiaomar1978-hub

Copy link
Copy Markdown
Contributor Author

pre-commit.ci fix: Applied ruff format to ci/tools/tests/test_ci_pr_cuda_core_compat.py (pre-commit run https://results.pre-commit.ci/run/github/381173759/1786751697.7FNpRYiJSZCR8Xfq95KQYw reformatted 1 file; autofix is disabled on this repo so pushed manually).

Review follow-up: Also fixed the wheel-download flags — test-pathfinder / test-bindings stay at defaults so nightly-cuda-core can download PR-built artifacts (see commit 0e4c3207ae).

@mdboom
mdboom requested review from kkraus14 and mdboom August 17, 2026 21:32
@atiaomar1978-hub

Copy link
Copy Markdown
Contributor Author

Cc: @mdboom @kkraus14 — friendly nudge for review when you have a moment.

This PR wires released cuda-core compat into PR CI (#2449): when detect-changes flags bindings-related paths, test-cuda-core-linux-64 runs the existing nightly-cuda-core mode using PR-built pathfinder/bindings wheels + released cuda-core from PyPI, and the checks aggregator expects success only in that case (skipped otherwise).

Since the last update:

  • Fixed wheel-download flags so test-pathfinder / test-bindings stay at defaults and the job can fetch PR artifacts (0e4c3207ae)
  • Added guardrail tests in ci/tools/tests/test_ci_pr_cuda_core_compat.py (6 passed locally; pre-commit/ruff applied)

Worth a look:

  • .github/workflows/ci.yml — new test-cuda-core-linux-64 job + conditional checks gate
  • ci/tools/tests/test_ci_pr_cuda_core_compat.py — YAML wiring guardrails vs ci-nightly.yml

Happy to adjust scope or naming if you'd prefer a lighter/different trigger. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI doesn't test the latest release of cuda_core against cuda_bindings main

1 participant