cuda.core: add tests for ObjectCode.from_library#2281
Open
lijinf2 wants to merge 1 commit into
Open
Conversation
Contributor
github-actions
Bot
added
CI/CD
Contributor
Author
|
/ok to test a0f1507 |
|
Member
|
Thanks, Jinfeng! Technically we already tested But I wouldn't complain for completeness 🙂 Let me get back to review tomorrow... |
leofang
requested changes
Jun 30, 2026
leofang
left a comment
leofang
left a comment
Member
There was a problem hiding this comment.
Let's try to reduce the boilerplate code. I understand that it's a lot cheaper to just generate code using agents. But there is really no good reason to add same code over and over. pytest parametrization can go a long way.
|
|
||
|
|
||
| @pytest.fixture(scope="module") | ||
| def get_saxpy_library(): |
Member
There was a problem hiding this comment.
Consolidate this fixture with get_saxpy_object above.
| assert mod_obj.code_type == "library" | ||
|
|
||
|
|
||
| def test_object_code_load_library_with_linker(get_saxpy_library, init_cuda): |
Member
There was a problem hiding this comment.
Consolidate the test with test_object_code_load_object_with_linker above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #663.
Adds tests for
ObjectCode.from_libraryand extends the saxpy test-binary infrastructure from #2193.build_test_binaries.sh: packagesaxpy.ointosaxpy.afor Linux /saxpy.libfor Windows vianvcc -libbuild-wheel.yml): upload library artifacts alongside object fixturestest_module.py: newget_saxpy_libraryfixture and three tests mirroringfrom_objectcoverage (bytes, file path, linker integration)Checklist