Add CloudXRLauncher CLI helpers for optional in-process runtime launch.#700
Add CloudXRLauncher CLI helpers for optional in-process runtime launch.#700nv-jakob wants to merge 1 commit into
Conversation
|
📝 Docs preview is not auto-deployed for fork PRs. A maintainer with write access to |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| help=( | ||
| "Launch the CloudXR runtime and WSS proxy in-process before running " | ||
| "(default: true). Pass --no-launch-cloudxr-runtime when the runtime is " | ||
| "already running (e.g. after sourcing ~/.cloudxr/run/cloudxr.env)." |
There was a problem hiding this comment.
since we are here, maybe add a arg for --cloudxr-install-dir as well (default to ~/.cloudxr)
There was a problem hiding this comment.
Hmm, is it actually install dir? We don't install anything there right? It's more like run dir right?
There was a problem hiding this comment.
right... the naming is probably not perfect. I think we can update it.
5ef860e to
c68d566
Compare
aristarkhovNV
left a comment
There was a problem hiding this comment.
CLI helpers being optional ideally should not bloat the launcher api to keep it focused on its one core function. Keeping CLI helpers separate from the core launcher class would keep the door open for adding more such helpers in the future based on different arg parsers, env vars, etc.
patterm be like:
ArgParseLaunchHelper.register(parser)
with ArgParseLaunchHelper(parser): # optionally creates the launcher within the helper context
...Expose argparse helpers so embedding apps and examples can default to launching the CloudXR runtime and WSS proxy, with --no-launch-cloudxr-runtime for environments where the runtime is already running. Signed-off-by: Jakob Bornecrantz <tbornecrantz@nvidia.com>
c68d566 to
8429356
Compare
Expose argparse helpers so embedding apps and examples can default to launching the CloudXR runtime and WSS proxy, with --no-launch-cloudxr-runtime for environments where the runtime is already running.
Description
Partial fix for #696
Fixes #(issue)
Type of change
Testing
Ran the added test
Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCOSummary by CodeRabbit