🎨 Palette: Replace .onTapGesture with Button for improved list row accessibility - #111
🎨 Palette: Replace .onTapGesture with Button for improved list row accessibility#111NSEvent wants to merge 3 commits into
Conversation
Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughMacro and script row edit areas now use SwiftUI ChangesAccessible row editing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift (1)
182-203: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winMake both primary row buttons announce their edit action.
The primary macro/script row buttons currently rely on inferred row content labels, so they need explicit action-oriented accessibility labels for screen readers.
MacroListView.swift: apply the label/hint to the primary row button and use the same approach for the duplicate icon button if it also opens the editor.ScriptListView.swift: apply the label/hint to the primary row button and use the same approach for the duplicate icon button if it also opens the editor.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift` around lines 182 - 203, Update the primary row buttons in MacroListView.swift (lines 182-203) and ScriptListView.swift (lines 191-219) with explicit accessibility labels and hints that announce their edit action. Also apply the same label and hint to each duplicate icon button in both files if its action opens the editor; otherwise leave those buttons unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift`:
- Around line 182-203: Update the primary row buttons in MacroListView.swift
(lines 182-203) and ScriptListView.swift (lines 191-219) with explicit
accessibility labels and hints that announce their edit action. Also apply the
same label and hint to each duplicate icon button in both files if its action
opens the editor; otherwise leave those buttons unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8af3b181-4613-4e92-9998-0c8569d191b8
📒 Files selected for processing (3)
.Jules/palette.mdXboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swiftXboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift
Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
1 participant
Replaced
.onTapGesturewithButton(action: onEdit)and.buttonStyle(.plain)inMacroListView.swiftandScriptListView.swift. This improves accessibility by providing proper button semantics for screen readers (like VoiceOver) and enables native keyboard navigation (e.g., triggering via Space/Return) without altering the visual appearance of the list rows. Also added a journal entry in.Jules/palette.mdto document this critical learning.PR created automatically by Jules for task 14098994546877272531 started by @NSEvent
Summary by CodeRabbit
Accessibility
Documentation