fix: respect model display_name for kimi-for-coding#2174
Open
tears-mysthrala wants to merge 1 commit into
Open
fix: respect model display_name for kimi-for-coding#2174tears-mysthrala wants to merge 1 commit into
tears-mysthrala wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a hardcoded display-name override so UI surfaces the provider-returned display_name (e.g., “Kimi-k2.6”) instead of forcing “kimi-for-coding”, improving model name presentation across the CLI UI.
Changes:
- Deleted the special-case mapping that normalized
("kimi-for-coding", "kimi-code")to"kimi-for-coding"inmodel_display_name(). - Ensures callers that already pass
LLMModel.display_namecan surface the backend-provided name without being overridden.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tears-mysthrala
force-pushed
the
fix-model-display-name-for-kimi-code
branch
from
22ec22a to
369aea0
Compare
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #2175
Description
Removes the hardcoded override in
model_display_name()that forced "kimi-for-coding" and "kimi-code" to always display as "kimi-for-coding", ignoring thedisplay_nameprovided by the backend (e.g. "Kimi-k2.6"). The backend already returns the correct display name via the /models endpoint, and it is correctly persisted in the config file — this fix simply allows the UI to actually show it.Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.