Skip to content

Update Set-SPOTenant.md#871

Merged
aditisrivastava07 merged 6 commits intoMicrosoftDocs:mainfrom
divyachapan:patch-2
Apr 24, 2025
Merged

Update Set-SPOTenant.md#871
aditisrivastava07 merged 6 commits intoMicrosoftDocs:mainfrom
divyachapan:patch-2

Conversation

@divyachapan
Copy link
Copy Markdown
Contributor

@divyachapan divyachapan commented Apr 23, 2025

PubOps Review Feedback

Fixing description of parameter AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 2f89bfb:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md 💡Suggestion View (sharepoint-ps) Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md

  • Line 0, Column 0: [Suggestion: other-site-link-broken - See documentation] Link 'https://support.office.com/article/Provision-the-Shared-with-Everyone-folder-in-OneDrive-for-Business-6bb02c91-fd0b-42ba-9457-3921cb6dc5b2' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

### -AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled
Enables or disables web property bag update when DenyAddAndCustomizePages is enabled. When AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled is set to $true, web property bag can be updated even if DenyAddAndCustomizePages is turned on when the user had AddAndCustomizePages (prior to DenyAddAndCustomizePages removing it).

Enables or disables web property bag updates in all sites in the tenant. When AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled is set to $true, the web property bag can be updated even if the Add And Customize Pages right is denied on a site collection.
Copy link
Copy Markdown
Contributor

@samkabue samkabue Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled

add bacticks

`AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled`
``` #Closed

### -AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled
Enables or disables web property bag update when DenyAddAndCustomizePages is enabled. When AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled is set to $true, web property bag can be updated even if DenyAddAndCustomizePages is turned on when the user had AddAndCustomizePages (prior to DenyAddAndCustomizePages removing it).

Enables or disables web property bag updates in all sites in the tenant. When AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled is set to $true, the web property bag can be updated even if the Add And Customize Pages right is denied on a site collection.
Copy link
Copy Markdown
Contributor

@samkabue samkabue Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$true

add backticks

`$true`
``` #Closed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divyachapan should be backtick
` not '

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 4384ade:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md 💡Suggestion View (sharepoint-ps) Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md

  • Line 0, Column 0: [Suggestion: other-site-link-broken - See documentation] Link 'https://support.office.com/article/Provision-the-Shared-with-Everyone-folder-in-OneDrive-for-Business-6bb02c91-fd0b-42ba-9457-3921cb6dc5b2' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 461582b:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md 💡Suggestion View (sharepoint-ps) Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md

  • Line 0, Column 0: [Suggestion: other-site-link-broken - See documentation] Link 'https://support.office.com/article/Provision-the-Shared-with-Everyone-folder-in-OneDrive-for-Business-6bb02c91-fd0b-42ba-9457-3921cb6dc5b2' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Default value: False
Accept pipeline input: False
Accept wildcard characters: False
```
Copy link
Copy Markdown
Contributor

@samkabue samkabue Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed -- the backend no longer has this setter param #Closed

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 33075e6:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md 💡Suggestion View (sharepoint-ps) Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md

  • Line 0, Column 0: [Suggestion: other-site-link-broken - See documentation] Link 'https://support.office.com/article/Provision-the-Shared-with-Everyone-folder-in-OneDrive-for-Business-6bb02c91-fd0b-42ba-9457-3921cb6dc5b2' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 031a4da:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md 💡Suggestion View (sharepoint-ps) Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md

  • Line 0, Column 0: [Suggestion: other-site-link-broken - See documentation] Link 'https://support.office.com/article/Provision-the-Shared-with-Everyone-folder-in-OneDrive-for-Business-6bb02c91-fd0b-42ba-9457-3921cb6dc5b2' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Copy Markdown
Contributor

@samkabue samkabue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@samkabue samkabue added the Sign off The pull request is ready to be reviewed and merged by PubOps label Apr 23, 2025
@Ruchika-mittal01 Ruchika-mittal01 self-assigned this Apr 23, 2025
@Ruchika-mittal01 Ruchika-mittal01 added the In review PubOps is reviewing the pull request label Apr 23, 2025
@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 9176125:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md 💡Suggestion View (sharepoint-ps) Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md

  • Line 0, Column 0: [Suggestion: other-site-link-broken - See documentation] Link 'https://support.office.com/article/Provision-the-Shared-with-Everyone-folder-in-OneDrive-for-Business-6bb02c91-fd0b-42ba-9457-3921cb6dc5b2' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Ruchika-mittal01
Copy link
Copy Markdown
Contributor

Ruchika-mittal01 commented Apr 23, 2025

Hi @divyachapan,

Following are blocking issues that need to be resolved before we can merge:

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md

Line 779: Provision the Shared with Everyone folder in OneDrive for Business.

The link is broken.


Reference

Criteria used for pull request reviews

Blocking

  • All links resolve correctly.

After you resolve the blocking issues, remove the Back to submitter label and add the Sign off label again.

If you need help resolving issues in this PR, post your question in the Ask an Admin Teams Channel.

Thanks,
Ruchika

@Ruchika-mittal01 Ruchika-mittal01 added Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates and removed In review PubOps is reviewing the pull request Sign off The pull request is ready to be reviewed and merged by PubOps labels Apr 23, 2025
@samkabue
Copy link
Copy Markdown
Contributor

samkabue commented Apr 23, 2025

@Ruchika-mittal01 -- that error was not introduced by @divyachapan's PR -- it already exists, so I don't think it should be him fixing it as he doesn't own that param ProvisionSharedWithEveryoneFolder where that problematic URL is defined. I'll try and look for the owner of that param, in the meantime I don't think there's anything that he can do here.

@samkabue samkabue added Sign off The pull request is ready to be reviewed and merged by PubOps and removed Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates labels Apr 24, 2025
@aditisrivastava07 aditisrivastava07 self-assigned this Apr 24, 2025
@aditisrivastava07 aditisrivastava07 added the In review PubOps is reviewing the pull request label Apr 24, 2025
@aditisrivastava07 aditisrivastava07 removed their assignment Apr 24, 2025
@aditisrivastava07 aditisrivastava07 removed the In review PubOps is reviewing the pull request label Apr 24, 2025
@aditisrivastava07 aditisrivastava07 self-assigned this Apr 24, 2025
@aditisrivastava07 aditisrivastava07 added the In review PubOps is reviewing the pull request label Apr 24, 2025
@aditisrivastava07 aditisrivastava07 merged commit 7a38a07 into MicrosoftDocs:main Apr 24, 2025
17 checks passed
@garycentric
Copy link
Copy Markdown
Contributor

@samkabue Thank you for the background information. For PRs in Magic, reviewers are expected to request fixes from whomever has submitted a PR, rather than try to figure out who might be more or less responsible for providing the fix. This works well for timely updates in repos where the content is maintained mostly by writers, but probably less well in PowerShell repos that don't have clear ownership. So, we'll all benefit from your effort to figure out who could provide a fix, as well as your comments when a contributor can't provide a resolution. PR reviewers rarely have domain knowledge of the content.

The link that's now bad was originally migrated in from some other repo by PR #10. From what I've found online about Shared with Everyone in OneDrive for Business, the whole sentence with the bad link should be removed, because I haven't found a current page on microsoft.com that talks about Shared with Everyone. Also, -ProvisionSharedWithEveryoneFolder should probably have its default changed from true to false, because that folder is apparently no longer provisioned by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

In review PubOps is reviewing the pull request Microsoft submitter Sign off The pull request is ready to be reviewed and merged by PubOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants