Update Set-SPOTenant.md#871
Conversation
|
Learn Build status updates of commit 2f89bfb: 💡 Validation status: suggestions
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
| ### -AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled | ||
| Enables or disables web property bag update when DenyAddAndCustomizePages is enabled. When AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled is set to $true, web property bag can be updated even if DenyAddAndCustomizePages is turned on when the user had AddAndCustomizePages (prior to DenyAddAndCustomizePages removing it). | ||
|
|
||
| Enables or disables web property bag updates in all sites in the tenant. When AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled is set to $true, the web property bag can be updated even if the Add And Customize Pages right is denied on a site collection. |
| ### -AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled | ||
| Enables or disables web property bag update when DenyAddAndCustomizePages is enabled. When AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled is set to $true, web property bag can be updated even if DenyAddAndCustomizePages is turned on when the user had AddAndCustomizePages (prior to DenyAddAndCustomizePages removing it). | ||
|
|
||
| Enables or disables web property bag updates in all sites in the tenant. When AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled is set to $true, the web property bag can be updated even if the Add And Customize Pages right is denied on a site collection. |
|
Learn Build status updates of commit 4384ade: 💡 Validation status: suggestions
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Learn Build status updates of commit 461582b: 💡 Validation status: suggestions
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
| Default value: False | ||
| Accept pipeline input: False | ||
| Accept wildcard characters: False | ||
| ``` |
There was a problem hiding this comment.
this should be removed -- the backend no longer has this setter param #Closed
|
Learn Build status updates of commit 33075e6: 💡 Validation status: suggestions
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Learn Build status updates of commit 031a4da: 💡 Validation status: suggestions
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Learn Build status updates of commit 9176125: 💡 Validation status: suggestions
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Hi @divyachapan, Following are blocking issues that need to be resolved before we can merge: sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md Line 779: Provision the Shared with Everyone folder in OneDrive for Business. The link is broken. Reference Criteria used for pull request reviews Blocking
After you resolve the blocking issues, remove the Back to submitter label and add the Sign off label again. If you need help resolving issues in this PR, post your question in the Ask an Admin Teams Channel. Thanks, |
|
@Ruchika-mittal01 -- that error was not introduced by @divyachapan's PR -- it already exists, so I don't think it should be him fixing it as he doesn't own that param |
|
@samkabue Thank you for the background information. For PRs in Magic, reviewers are expected to request fixes from whomever has submitted a PR, rather than try to figure out who might be more or less responsible for providing the fix. This works well for timely updates in repos where the content is maintained mostly by writers, but probably less well in PowerShell repos that don't have clear ownership. So, we'll all benefit from your effort to figure out who could provide a fix, as well as your comments when a contributor can't provide a resolution. PR reviewers rarely have domain knowledge of the content. The link that's now bad was originally migrated in from some other repo by PR #10. From what I've found online about Shared with Everyone in OneDrive for Business, the whole sentence with the bad link should be removed, because I haven't found a current page on microsoft.com that talks about Shared with Everyone. Also, -ProvisionSharedWithEveryoneFolder should probably have its default changed from true to false, because that folder is apparently no longer provisioned by default. |
PubOps Review Feedback
Fixing description of parameter AllowWebPropertyBagUpdateWhenDenyAddAndCustomizePagesIsEnabled