Skip to content

fix: remove dead deprecated _process_interactive_prompt_async#2341

Merged
MervinPraison merged 1 commit into
mainfrom
claude/issue-2340-20260626-1610
Jun 26, 2026
Merged

fix: remove dead deprecated _process_interactive_prompt_async#2341
MervinPraison merged 1 commit into
mainfrom
claude/issue-2340-20260626-1610

Conversation

@praisonai-triage-agent

@praisonai-triage-agent praisonai-triage-agent Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Fixes #2340

Summary

Removes the explicitly deprecated, unreferenced private method _process_interactive_prompt_async from src/praisonai/praisonai/cli/main.py.

Details

  • Repository-wide grep confirmed zero callers other than the definition itself.
  • The method was a thin shim delegating to _submit_prompt_to_worker, which is the live method called directly elsewhere.
  • Active interactive path (_submit_prompt_to_worker / _process_interactive_prompt) is untouched.

Layer

Wrapper only. No core/tools/plugins changes. No public API affected (private, unreferenced).

Validation

  • grep -rn _process_interactive_prompt_async src/praisonai now returns nothing.
  • Syntax validated via ast.parse.

Generated with Claude Code

Summary by CodeRabbit

  • Refactor
    • Streamlined interactive prompt handling by removing an unused compatibility path, reducing internal complexity with no expected change to the user experience.

…2340)

Co-authored-by: MervinPraison <MervinPraison@users.noreply.github.com>
@MervinPraison

Copy link
Copy Markdown
Owner

@coderabbitai review

@MervinPraison

Copy link
Copy Markdown
Owner

/review

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more β†’

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account β†’

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us β†’

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
βœ… Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1eb246d1-a77c-4c1a-b1da-db6f3affd461

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between b5a45bf and fb71356.

πŸ“’ Files selected for processing (1)
  • src/praisonai/praisonai/cli/main.py
πŸ’€ Files with no reviewable changes (1)
  • src/praisonai/praisonai/cli/main.py

πŸ“ Walkthrough

Walkthrough

Removed the deprecated _process_interactive_prompt_async wrapper from CLI interactive prompt handling, leaving the active prompt path unchanged.

Changes

CLI interactive prompt cleanup

Layer / File(s) Summary
Remove deprecated async wrapper
src/praisonai/praisonai/cli/main.py
Deleted the private _process_interactive_prompt_async method that forwarded prompts to _submit_prompt_to_worker.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • MervinPraison

Poem

I nibbled the old wrapper away, πŸ‡
A prompt now hops the live route today.
No extra burrow, no dusty stack,
Just swift little paws on the CLI track.
Thump-thump! The code path stays neat and bright.

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The title clearly and concisely describes the main change: removing the deprecated _process_interactive_prompt_async method.
Linked Issues check βœ… Passed The change matches #2340 by deleting the private deprecated shim with no other behavioral changes.
Out of Scope Changes check βœ… Passed The PR only removes the targeted dead method and does not introduce unrelated changes.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
πŸ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-2340-20260626-1610

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@MervinPraison

Copy link
Copy Markdown
Owner

@copilot Do a thorough review of this PR. Read ALL existing reviewer comments above from Qodo, Coderabbit, and Gemini first β€” incorporate their findings.

Review areas:

  1. Bloat check: Are changes minimal and focused? Any unnecessary code or scope creep?
  2. Security: Any hardcoded secrets, unsafe eval/exec, missing input validation?
  3. Performance: Any module-level heavy imports? Hot-path regressions?
  4. Tests: Are tests included? Do they cover the changes adequately?
  5. Backward compat: Any public API changes without deprecation?
  6. Code quality: DRY violations, naming conventions, error handling?
  7. Address reviewer feedback: If Qodo, Coderabbit, or Gemini flagged valid issues, include them in your review
  8. Suggest specific improvements with code examples where possible

@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes a deprecated private interactive prompt wrapper. The main changes are:

  • Deleted _process_interactive_prompt_async from the CLI implementation.
  • Left the active _submit_prompt_to_worker and _process_interactive_prompt paths unchanged.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
src/praisonai/praisonai/cli/main.py Removed the deprecated private async prompt shim without changing the active interactive prompt flow.

Reviews (1): Last reviewed commit: "fix: remove dead deprecated _process_int..." | Re-trigger Greptile

@MervinPraison

Copy link
Copy Markdown
Owner

@claude You are the FINAL architecture reviewer. If the branch is under MervinPraison/PraisonAI (not a fork), you are able to make modifications to this branch and push directly. SCOPE: Focus ONLY on Python packages (praisonaiagents, praisonai). Do NOT modify praisonai-rust or praisonai-ts. Read ALL comments above from Gemini, Qodo, CodeRabbit, and Copilot carefully before responding.

Phase 1: Review per AGENTS.md

  1. Protocol-driven: check heavy implementations vs core SDK
  2. Backward compatible: ensure zero feature regressions
  3. Performance: no hot-path regressions
  4. SDK value: review in depth whether the change genuinely adds value to the SDK β€” never add features for the sake of adding them. It must strengthen the SDK (simpler, more user-friendly, robust, world-class, secure). If it does not clearly add value, request changes or recommend rejecting/closing rather than merging scope creep
  5. Do not bloat the Agent class with additional params β€” only if absolutely required; we already support many params.

Phase 2: FIX Valid Issues
5. For any VALID bugs or architectural flaws found by Gemini, CodeRabbit, Qodo, Copilot, or any other reviewer: implement the fix
6. Push all code fixes directly to THIS branch (do NOT create a new PR)
7. Comment a summary of exact files modified and what you skipped

Phase 3: Final Verdict
8. If all issues are resolved, approve the PR / close the Issue
9. If blocking issues remain, request changes / leave clear action items

@praisonai-triage-agent

praisonai-triage-agent Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Claude finished @MervinPraison's task β€”β€” View job


Final Architecture Review β€” PR #2341 βœ… APPROVED

  • Read AGENTS.md guidelines
  • Verify zero callers of _process_interactive_prompt_async
  • Confirm active path untouched
  • Review prior reviewer feedback (CodeRabbit, Greptile, Qodo, Copilot)
  • Final verdict

Phase 1 β€” Architecture Review (per AGENTS.md)

Criterion Result
Routing βœ… Wrapper-only change (praisonai/cli/main.py). No core SDK, tools, or plugins touched. Correctly scoped.
Protocol-driven βœ… N/A β€” pure deletion, no new implementation.
Backward compatible βœ… Method was private (_-prefixed) and explicitly deprecated. No public API affected.
Performance βœ… No hot-path impact. The deleted shim was never invoked.
SDK value βœ… Genuinely strengthens the SDK by removing dead code β€” reduces surface area & maintenance burden. No scope creep.
Agent class bloat βœ… N/A β€” no Agent params added.

Phase 2 β€” Validation of Reviewer Feedback

  • CodeRabbit: No actionable comments. βœ…
  • Greptile: 5/5 confidence, safe to merge. βœ…
  • Qodo: Reviews paused (not a code finding). βœ…
  • Copilot: No blocking issues raised.

Independent verification:

  • grep -rn _process_interactive_prompt_async β†’ zero matches repo-wide (confirmed; only the deleted definition existed). βœ…
  • Active interactive path verified intact: _submit_prompt_to_worker (main.py:6896) and _process_interactive_prompt (main.py:6905) are self-contained and called directly at main.py:6710. βœ…

No valid bugs or architectural flaws found. No fixes required β€” nothing to push.

Phase 3 β€” Final Verdict

βœ… APPROVED. This is a textbook minimal, focused, backward-compatible dead-code removal (0 additions / 8 deletions). It cleanly resolves #2340 with no regressions and no scope creep. Ready to merge.

Note: I cannot formally approve via GitHub's review API for security reasons, but from an architecture standpoint this PR has no blocking issues.
β€’ Branch: claude/issue-2340-20260626-1610

@MervinPraison

Copy link
Copy Markdown
Owner

MERGE_GATE_VERDICT: APPROVE

Automated fallback β€” Claude assess did not post a verdict comment (e.g. GitHub MCP unavailable).
All deterministic merge gates passed.

@MervinPraison MervinPraison merged commit d75cf6b into main Jun 26, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead deprecated method _process_interactive_prompt_async in cli/main.py

1 participant