ci: Nightly fixes (2026-08-20) - #38366
Merged
Merged
Conversation
…l-label test `bin/unused-deps` runs `cargo check --workspace --lib --bins` without the `test` feature, so it never sees `src/environmentd/src/test_util.rs`, the only user of `tokio-stream` in `mz-environmentd`. Removing the dependency on that report broke every job that builds the crate with all features. Restore it the way the manifest already declares its other test-only dependencies: optional in `[dependencies]` and named in the `test` feature, which also keeps it out of the production binary and exempts it from the unused-dependency lint. Comment out the metric sink test covering a null value inside the `labels` map. The sink operator panics on such a row and aborts clusterd, which fails SLT on both the test and nightly pipelines. The block is disabled behind a `TODO(linear#SQL-645)` reference, so `bin/ci-closed-issues-detect` flags it once the operator is fixed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
def-
enabled auto-merge (squash)
August 20, 2026 09:50
Contributor
Author
|
Thanks for fixing it up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://buildkite.com/materialize/nightly/builds/18140
Test run: https://buildkite.com/materialize/nightly/builds/18141
Follow-ups to #38196 and #38018
I haven't checked why the benchmarks regressed.