Remove the query logger when the query_logger() block raises - #1373
Merged
Merged
Conversation
query_logger() removed its callback after a bare yield, so any exception in the with-block, such as a failing query, left the logger attached to the connection. Pooled connections then kept reporting later, unrelated queries to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection.query_logger()removed its callback after a bareyield, so if anything inside thewithblock raises, for example a query that fails, the callback stays registered on the connection. With a pool, that connection is handed to other code later and the logger keeps receiving those unrelated queries, and it is never released.The fix moves
remove_query_logger()into afinally. I addedtest_logging_context_removed_on_errortotests/test_logging.py. It fails on master with the logger still attached (1 != 0) and passes with the change.tests.test_loggingand flake8 pass locally.