Skip to content

Use two-pass IPO for OpenMP offload as well #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbryngelson wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −2
Open

Use two-pass IPO for OpenMP offload as well #1880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
075b901
ci: use two-pass IPO for OpenMP offload as well
sbryngelson Sep 13, 2026
baf9598
Merge remote-tracking branch 'origin/master' into tmp-1880
sbryngelson Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions cmake/MFCTargets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function(MFC_SETUP_TARGET)
set(IPO_TARGETS ${ARGS_TARGET})
# Here we need to split into "library" and "executable" to perform IPO on the NVIDIA compiler.
# A little hacky, but it *is* an edge-case for *one* compiler.
if (NVHPC_USE_TWO_PASS_IPO AND NOT(MFC_OpenMP AND ARGS_OpenMP))
if (NVHPC_USE_TWO_PASS_IPO)
# nvfortran -Mextract does not produce .o files, only inline library
# data. An OBJECT library with -Mextract causes CMake to rebuild
# everything on every build because the expected .o outputs never
Expand Down Expand Up @@ -70,7 +70,14 @@ exit 0
# six-equation relaxation kernel silently drops the
# internal-energy update, leaving alpha and
# alpha_rho correct and int_en zero.
foreach(_no_inline_file m_start_up m_cbc m_pressure_relaxation)
set(_no_inline_files m_start_up m_cbc m_pressure_relaxation)
# OpenMP offload additionally segfaults fort2 (signal 11) inlining into
# m_data_output, which OpenACC compiles cleanly. Scoped so the OpenACC
# build keeps full inlining there.
if (MFC_OpenMP AND ARGS_OpenMP)
list(APPEND _no_inline_files m_data_output)
endif()
foreach(_no_inline_file ${_no_inline_files})
set_source_files_properties(
"${CMAKE_BINARY_DIR}/fypp/${ARGS_TARGET}/${_no_inline_file}.fpp.f90"
TARGET_DIRECTORY ${ARGS_TARGET}
Expand Down
Loading