Skip to content

Address leftover review comments from merged PRs #2083

Open

Description

@sbryngelson

Follow-ups to review comments left open on PRs that are already merged. Each item was checked against current master before it was changed. Results do not change: the Fortran edits are comments plus one explicit real(wp) cast, and index.html is whitespace only (git diff -w is empty).

Bug

Minor

Not changed

  • docs: add five flapping-flight and jet runs to the showcase #1912, "512 GCDs" (thread): the PR first had "240-512 GCDs". A later commit on that PR (f6f6ce1, "Update accelerators for Seagull simulation") deliberately set it to "512 GCDs", and the merged PR description matches. There is no case file in the repo to check it against. Going back to the range would undo that deliberate edit, so the entry stays as it is.

Verification

  • ./mfc.sh format: clean
  • ./mfc.sh precheck (formatting, spelling, toolchain and source lint, doc refs, param docs, example validation): all 7 checks pass
  • ./mfc.sh lint (ruff + toolchain unit tests): 794 passed, 2 skipped
  • pytest toolchain/mfc/test_thermochem.py with CCE ftn: 16 passed, 1 skipped
  • bash -n on preflight.sh and submit-slurm-job.sh: OK
  • ./mfc.sh validate on both edited examples: pass. A grcbc_in case with fields removed still reports them in the same order.
  • ./mfc.sh build -j 8 (Frontier, CPU): OK
  • ./mfc.sh test -j 8 -% 10 on a Frontier CPU node: 72 passed, 0 failed
  • ./mfc.sh test -j 8 -o IBM (includes the fixed-dt prescribed-kinematics and moving-IB goldens): 61 passed, 0 failed
  • ./mfc.sh test -o <6 grcbc UUIDs> (1D/2D/3D grcbc x/y/z): 6 passed, 0 failed

Status: a fix/implementation for this is already written, in a pull request that has been closed for queue management.

  • Closed PR: Address leftover review comments from merged PRs #1959
  • Branch: ai-review-followups on the sbryngelson fork, at 91422f0389 (branch retained, not deleted)
  • Size: +80/-68 across 12 files, 10 commits
  • Where it sat: MERGEABLE; CI 19 checks queued (master was merged in today, so CI had not reported yet)
  • Reopen with: gh pr reopen 1959 -R MFlowCode/MFC

It was merge-clean and up to date with master, and it is small.

Tracked with pr-to-do. Filed with Claude Code.

Activity

  1. added
    pr-to-doFix already written in a closed PR; reopen when review capacity allows
    on Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pr-to-doFix already written in a closed PR; reopen when review capacity allows

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions