Skip to content

feat(gamepads): add DualShock4#23

Merged
ReenigneArcher merged 1 commit into
masterfrom
feat/gamepads/add-DualShock4
Jun 22, 2026
Merged

feat(gamepads): add DualShock4#23
ReenigneArcher merged 1 commit into
masterfrom
feat/gamepads/add-DualShock4

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Adds DS4 profile.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@read-the-docs-community

read-the-docs-community Bot commented Jun 22, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.39785% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.77%. Comparing base (873089f) to head (d73996b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/core/report.cpp 93.25% 11 Missing and 1 partial ⚠️
src/platform/linux/uhid_backend.cpp 80.43% 5 Missing and 4 partials ⚠️
src/core/profiles.cpp 94.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   86.50%   86.77%   +0.27%     
==========================================
  Files          12       12              
  Lines        3586     3835     +249     
  Branches     1230     1321      +91     
==========================================
+ Hits         3102     3328     +226     
- Misses        373      393      +20     
- Partials      111      114       +3     
Flag Coverage Δ
Linux-Clang 70.12% <62.50%> (-0.24%) ⬇️
Linux-GCC 82.04% <83.47%> (+0.01%) ⬆️
Windows-MSVC 86.01% <93.43%> (+0.69%) ⬆️
Windows-MinGW-UCRT64 77.68% <84.10%> (+0.61%) ⬆️
macOS 69.22% <61.97%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/include/libvirtualhid/types.hpp 100.00% <ø> (ø)
src/platform/windows/control_protocol.hpp 100.00% <100.00%> (ø)
src/core/profiles.cpp 89.70% <94.33%> (+1.47%) ⬆️
src/platform/linux/uhid_backend.cpp 87.27% <80.43%> (-0.31%) ⬇️
src/core/report.cpp 90.66% <93.25%> (+0.89%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873089f...d73996b. Read the comment docs.

@ReenigneArcher ReenigneArcher force-pushed the feat/gamepads/add-DualShock4 branch from 0e4c493 to 410ee4b Compare June 22, 2026 00:52
@ReenigneArcher ReenigneArcher force-pushed the feat/gamepads/add-DualShock4 branch from 410ee4b to d73996b Compare June 22, 2026 01:06
@ReenigneArcher ReenigneArcher merged commit 2b8f6d5 into master Jun 22, 2026
25 checks passed
@ReenigneArcher ReenigneArcher deleted the feat/gamepads/add-DualShock4 branch June 22, 2026 01:11
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant