Skip to content

build(windows): use github.workspace path for signing files#21

Merged
ReenigneArcher merged 1 commit into
masterfrom
build/windows/fix-azure-signing
Jun 21, 2026
Merged

build(windows): use github.workspace path for signing files#21
ReenigneArcher merged 1 commit into
masterfrom
build/windows/fix-azure-signing

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Update Azure signing step to reference the full workspace path for the Windows driver catalog file (libvirtualhid.cat) by using ${{ github.workspace }}/.... Also switch the files field to a block scalar so the step can accept a multi-line list if needed. This avoids relative path resolution issues on the runner and prevents file-not-found errors during signing.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Update Azure signing step to reference the full workspace path for the Windows driver catalog file (libvirtualhid.cat) by using `${{ github.workspace }}/...`. Also switch the `files` field to a block scalar so the step can accept a multi-line list if needed. This avoids relative path resolution issues on the runner and prevents file-not-found errors during signing.
@read-the-docs-community

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.50%. Comparing base (c6eed48) to head (520339d).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   86.50%   86.50%           
=======================================
  Files          12       12           
  Lines        3586     3586           
  Branches     1230     1230           
=======================================
  Hits         3102     3102           
+ Misses        356      349    -7     
- Partials      128      135    +7     
Flag Coverage Δ
Linux-Clang 70.36% <ø> (ø)
Linux-GCC 82.03% <ø> (ø)
Windows-MSVC 85.32% <ø> (ø)
Windows-MinGW-UCRT64 77.07% <ø> (ø)
macOS 69.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6eed48...520339d. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit 9d50532 into master Jun 21, 2026
25 checks passed
@ReenigneArcher ReenigneArcher deleted the build/windows/fix-azure-signing branch June 21, 2026 22:07
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant