fix(input): don't send ALT when right-alt is remapped to meta#5318
Open
ap-1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Anish Pallati <i@anish.land>
2c23b75 to
8c51850
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
key_rightalt_to_key_winonly remaps the keycode (0xA5->0x5B), not the client'smodifiersbitmask. On clients where right-alt reports as alt (e.g. macOS right-option), packets sent while it's held still carryMODIFIER_ALT, so the synthetic-modifier check injects a real ALT and the host getsMETA + ALT + <key>instead ofMETA + <key>(e.g.Super+1binds fire asSuper+Alt+1).Clearing
MODIFIER_ALTfrom that check when right-alt is the only alt held and the remap is active avoids this; a real left-alt still passes through.Tested on Wayland/Hyprland with a macOS Moonlight client. With the remap on,
Super+<n>binds reach the compositor asSuper+<n>.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage