fix(rpm-versionlock): warn when dnf5 lockfile unreadable on Python <3.11 (#1462) - #1490
Closed
AquaticAzelf wants to merge 1 commit into
Closed
fix(rpm-versionlock): warn when dnf5 lockfile unreadable on Python <3.11 (#1462)#1490AquaticAzelf wants to merge 1 commit into
AquaticAzelf wants to merge 1 commit into
Conversation
markuslf
self-requested a review
August 28, 2026 07:10
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1462
get_dnf5_locks()returned[],[],[]whentomllibis unavailable (Python <3.11) even if/etc/dnf/versionlock.tomlexists, silently reporting OK.check-plugins/rpm-versionlock/rpm-versionlock:568now checks for the dnf5 lockfile existence whentomllib is Noneand returns[],[],["<lockfile> cannot be read, this needs Python 3.11 or newer"]via theignoredchannel, whichmain()already treats asSTATE_WARNand displays under "These configurations are read but applied to nothing".check-plugins/rpm-versionlock/unit-test/runremoves theNEEDS_TOMLLIBskip and makes those 7 testcases assertWARNwithcannot be read, this needs Python 3.11 or newerwhentomllibis missing, so the same tests pass on both old and new interpreters.Verified folder-locally:
python ./runpasses (48 tests) on Python 3.14 and simulatedtomllib=Nonecorrectly returns WARN for existing lockfile and OK for missing file.