Skip to content

Update status from Draft to Complete in GLSL_EXT_spirv_intrinsics#330

Merged
Tobski merged 1 commit into
mainfrom
Tobski-patch-1
Jun 23, 2026
Merged

Update status from Draft to Complete in GLSL_EXT_spirv_intrinsics#330
Tobski merged 1 commit into
mainfrom
Tobski-patch-1

Conversation

@Tobski

@Tobski Tobski commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@rdb

rdb commented Jun 11, 2026

Copy link
Copy Markdown

Would it be possible to defer this until I have proposed my amendments? I will try to get to it soon.

@Tobski

Tobski commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

This is functionally not a draft - we have a lot of code relying on the existing extension in production. That it's not tagged as such is spec bug, it's not reflective of reality. Any new functionality needs to be a new extension IMO.

@rdb

rdb commented Jun 23, 2026

Copy link
Copy Markdown

That's fine by me.

I have discovered a potential omission in the GL_EXT_spirv_intrinsics text. It doesn't specify whether spirv_literal can be used with a set-qualified instruction (ie. OpExtInst). The current glslang implementation doesn't seem to allow this (there's an assertion error). That's defensible, but then there should probably be wording in the spec to disallow this explicitly.

@Tobski

Tobski commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

That's fine by me.

Cool. I'll merge this then.

I have discovered a potential omission in the GL_EXT_spirv_intrinsics text. It doesn't specify whether spirv_literal can be used with a set-qualified instruction (ie. OpExtInst). The current glslang implementation doesn't seem to allow this (there's an assertion error). That's defensible, but then there should probably be wording in the spec to disallow this explicitly.

That is actually supposed to be allowed... do you have an example shader for this? And could you raise a glslang issue for it?

@Tobski Tobski merged commit 6ee5bdc into main Jun 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants