Repository navigation
DefaultTestSet fields are const in 1.13, don't try to change 'em - #137
kleinschmidt wants to merge 7 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 92.73% 92.88% +0.14%
==========================================
Files 7 7
Lines 482 492 +10
==========================================
+ Hits 447 457 +10
Misses 35 35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Only failures appear to be that the test failures don't pretty print in XML with a trailing line for some reason. If it were me I'd just update the reference tests since this doesn't seem like a meaningful change... |
Go ahead |
omus
left a comment
There was a problem hiding this comment.
Looks like there is a minor test flaw but othewise looking good
|
@kleinschmidt are you planning to follow up on this? |
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
|
I've gone ahead and added matrix entries for all supported minor versions of Julia on ubuntu, and test min/1/nightly on windows. |
This is probably the simplest possible fix to #136 , which just does not attempt to set the elapsed time on the default test set since those fields are now const. I've updated the reference tests for a few of the tests; the only difference is that there's no trailing new line in how some of the outputs are printed.
Finally, we were not testing on versions of julia that we support and have different reference outputs for; I've added CI jobs for every supported minor version of Julia on ubuntu, keeping windows only on min/1/nightly.
fixes #136