Add dims support to sort, sort!, sortperm and sortperm! - #117
Open
shreyas-omkar wants to merge 1 commit into
Open
Add dims support to sort, sort!, sortperm and sortperm!#117shreyas-omkar wants to merge 1 commit into
shreyas-omkar wants to merge 1 commit into
Conversation
Sort or permute each 1D slice along an integer `dims` independently, matching Base. The default `dims=:` keeps the existing flat behaviour. There is no batched sort kernel, so each element is tagged with its slice and the whole array is sorted once by (slice, value), then scattered back into place. sortperm carries the original index as the payload and uses it to break ties, keeping the permutation stable. This reuses the backend's tuned sort and runs unchanged on CPU and every GPU backend.
shreyas-omkar
force-pushed
the
sh/sort-dims
branch
from
August 24, 2026 09:47
8410490 to
b7b31ad
Compare
shreyas-omkar
changed the title
shreyas-omkar
marked this pull request as draft
August 24, 2026 09:49
Member
Author
|
@christiangnrd Please take a look. :) |
shreyas-omkar
marked this pull request as ready for review
August 26, 2026 06:51
Member
Author
NVIDIA RTX 5080 (CUDA 13.3.0)1D
1D
1D
N-D
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
dimskeyword tosort/sort!/sortperm/sortperm!for portable per-slice N-D sorting across CPU and every GPU backend, using the same tag-and-lexicographic-sort strategy as AMDGPU.jl #1033