Fall back to GPUArrays 1.12 handling#875
Open
kshyatt wants to merge 2 commits into
Open
Conversation
Member
|
Let's see what CI returns (if it does not OOM). Thanks for the addition! |
Member
|
Can you merge master into this branch to re-run the tests now that we moved to ParallelTestRunner.jl ? |
Member
Author
|
Do we not have the automatic branch rules on that would let me do this from the web UI? Annoying... |
Member
IDK - what's that? |
Member
|
Seems there are some failures in 1.12. Related to the changes I guess? Note that latest CI is avail on master |
Member
|
Seems there are still some of the 1.12 failures in |
Member
Author
|
Ah, I think the problem is the GPUArrays method doesn't handle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if this works...