make use of explicit rather than implicit imports of symbols#922
Merged
Conversation
|
This is an automated message.
|
baggepinnen
force-pushed
the
implicit_imports
branch
2 times, most recently
from
d708898 to
9291316
Compare
To prevent future breakage from name clashes introduced by modules we import exporting new names. Symbol lists derived from ExplicitImports.print_explicit_imports. Also drops stale explicit imports flagged by ExplicitImports: - BlasFloat (top-level ControlSystems) - PartitionedStateSpace (top-level timeresp) - issiso (top-level ControlSystems) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
baggepinnen
force-pushed
the
implicit_imports
branch
from
9291316 to
0d6cb14
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #922 +/- ##
==========================================
+ Coverage 91.54% 91.57% +0.02%
==========================================
Files 42 42
Lines 5609 5623 +14
==========================================
+ Hits 5135 5149 +14
Misses 474 474 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in order to prevent future breakage from name clashes introduced by modules we import exporting new names