Repository navigation
Conversation
c-dilks
commented
Aug 25, 2026
c-dilks
force-pushed
the
bank-name-check
branch
2 times, most recently
from
October 29, 2026 20:31
a172416 to
7d98b03
Compare
c-dilks
force-pushed
the
bank-name-check
branch
from
October 29, 2026 21:00
7d98b03 to
3ca2118
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some downstream code uses pattern matching of bank names; for example, the dataframe code replaces
::with_, since::is no good for dataframe column names.To prevent any other issues downstream, let's restrict the character set allowed for bank names.