Repository navigation
Run the oneMath develop branch tests nightly - #3176
Merged
Merged
Conversation
The `test_by_branch` job builds dpnp against the head of oneMath `develop`, so its failures come from upstream, not from the PR under test, while its two jobs (39-68 min each) add ~105 min of runner time to every push. It now runs on a nightly schedule and on manual dispatch only, and `test_by_tag` keeps running on pushes and PRs. The checkout uses the renamed `uxlfoundation/oneMath` repository instead of the `oneapi-src/oneMKL` redirect.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
November 8, 2026 18:22
ndgrigorian
approved these changes
Nov 8, 2026
ndgrigorian
left a comment
ndgrigorian
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, this change makes sense, we still retain per-PR jobs with a stable oneMath branch
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the changes to oneMath CI scheduling and checkout references.
No open issues 🎉
What changed in this PR
Moves oneMath develop testing out of push and pull-request runs into nightly and manual runs, reducing routine CI runner time while retaining tagged-version coverage.
Changes:
- Adds a nightly schedule at 03:17 UTC and a manual dispatch trigger.
- Restricts develop-branch tests to scheduled and manual runs; skips tagged-version tests on scheduled runs.
- Updates the checkout to
uxlfoundation/oneMathand renames related step labels and source-directory references.
| File | Description |
|---|---|
.github/workflows/check-onemath.yaml |
Adds triggers and job conditions, and updates oneMath checkout references and naming. |
Review effort: Balanced
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.22.0dev1=np2py314h8d9cdd5_6 ran successfully. |
Collaborator
|
coverage: 84.397%. remained the same — onemath-develop-nightly into master |
github-actions Bot
added a commit
that referenced
this pull request
Nov 8, 2026
The `Run tests with oneMath develop branch` jobs build dpnp against the head of oneMath `develop`. A failure there comes from upstream, not from the PR under test, while the two jobs take 39-68 min each, about 105 min of runner time per push (median of the last 6 `master` runs). This PR moves them off pushes and PRs: - `check-onemath.yaml` gets a nightly `schedule` (03:17 UTC) and a `workflow_dispatch` trigger. - `test_by_branch` runs only on `schedule` and `workflow_dispatch`. `test_by_tag` keeps running on pushes and PRs, and is skipped on the nightly run. - The oneMath checkout uses the renamed `uxlfoundation/oneMath` repository instead of the `oneapi-src/oneMKL` redirect (its default branch is still `develop`), and the step names and the source directory variable say oneMath. Neither job is a required check. A failed nightly run shows in the Actions tab, and GitHub sends its notification to the user who last changed the `cron` line. On this PR the develop branch jobs show as skipped; the first nightly run after merge, or a manual dispatch, is the real check. 03d7f91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Run tests with oneMath develop branchjobs build dpnp against the head of oneMathdevelop. A failure there comes from upstream, not from the PR under test, while the two jobs take 39-68 min each, about 105 min of runner time per push (median of the last 6masterruns).This PR moves them off pushes and PRs:
check-onemath.yamlgets a nightlyschedule(03:17 UTC) and aworkflow_dispatchtrigger.test_by_branchruns only onscheduleandworkflow_dispatch.test_by_tagkeeps running on pushes and PRs, and is skipped on the nightly run.uxlfoundation/oneMathrepository instead of theoneapi-src/oneMKLredirect (its default branch is stilldevelop), and the step names and the source directory variable say oneMath.Neither job is a required check. A failed nightly run shows in the Actions tab, and GitHub sends its notification to the user who last changed the
cronline. On this PR the develop branch jobs show as skipped; the first nightly run after merge, or a manual dispatch, is the real check.