feat(linked): add vLLM grouped_topk provider - #908
Merged
Conversation
voltjia
force-pushed
the
feat/linked-grouped-topk-provider
branch
from
August 7, 2026 17:57
fbbb737 to
6c87a0e
Compare
voltjia
force-pushed
the
feat/linked-grouped-topk-provider
branch
3 times, most recently
from
August 8, 2026 01:04
7b32f24 to
36b8624
Compare
grouped_topk provider
voltjia
force-pushed
the
feat/linked-grouped-topk-provider
branch
from
August 8, 2026 02:52
36b8624 to
2a23f12
Compare
voltjia
marked this pull request as ready for review
August 8, 2026 11:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_moe_C::grouped_topk.grouped_topktest module.Motivation
InfiniOps currently carries a native
grouped_topkimplementation derived fromupstream serving kernels. The installed vLLM provider already exposes the
operation through the C10 Dispatcher, so this PR adds a thin linked adapter
without copying another provider kernel into the repository.
#906 is merged and provides the shared
vllm/_moe_C.*.solibrary mapping.N/A - no linked issue.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvementrefactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_HYGON)WITH_TORCH)Smoke Test Result
Remote environment: A100 with the Cornserve vLLM provider image, using an
operator-pruned Release build with
WITH_LINKED=ON.The smoke allowlist is unchanged.
Test Results on Supported Platforms
4 passed; native slot 0:13 passed, 1 skippedBenchmark / Performance Impact
N/A - no performance claim.
Notes for Reviewers
schema (
scoresandscores_with_bias), calls the provider on the caller'sstream, and copies the returned tuple into InfiniOps' output-tail tensors.
rounding, tie, and nonfinite behavior. It does not claim bitwise equivalence
with native slot 0. The native implementation remains the default and keeps
the existing InfiniOps contract.
tests/test_grouped_topk.pyexplicitly select slot 16and compare against the loaded vLLM operator. Without that provider, only those
cases skip; the native regression cases still run.