Repository navigation
A module declares the caches it loads through - #1373
Draft
jwrosewell wants to merge 13 commits into
Draft
jwrosewell wants to merge 13 commits into
jwrosewell wants to merge 13 commits into
Conversation
A deployment selects a loading cache for each feature in its own [cache.<name>] table, and core listed one feature, robots-txt, so a module's own cache was never selected and every one of its loads ran on every call. A builder now declares the caches its modules load through, by name, [cache.<name>] is read for each declared name with the same settings as [cache.robots-txt], and a table naming a cache no linked module declares is refused when the deployment starts, naming the ones that are declared.
A cache name no linked module declares is refused by validate_settings_for_deploy_with as it is when the caches are made, so a misspelt [cache.<name>] fails ts config validate and not the deployment. A builder declaring robots-txt, or a name another builder declares, is refused naming the builders. The seam probe declares seam-probe-answers and offers a loading cache of its own, and the Axum seam tests prove the table selects it from outside core. The guide names a fictional module.
The debug form of a report carries a backtrace where the test runner asks for one, as CI does, and the deploy check and startup raise the refusal on different stacks, so the comparison held only while both were inlined alike. The message is what the test is about.
…by message As with the probe's test: the debug form of a report carries a backtrace where the test runner asks for one, and the deploy check and the cache build raise the refusal on different stacks.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
crates/trusted-server-core/srccrates/trusted-server-adapter-axum/testscrates/testing/seam-probedocs/guideCHANGELOG.mdCargo.lockCloses
Closes #1320
Test plan
CI: 19 of 19 checks green, the fork's CI on 169d709 (jwrosewell#27).
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute serveChecklist
unwrap()in production code (clippy deniesunwrap_usedin CI)logmacros as AGENTS.md asks (notprintln!)On top of the fork's
fiftyone-cachingpin at the released 4.5.8 (#26). Issue: #1320.What this adds
A module declares the caches it loads through, by name, on its builder,
IntegrationBuilder::with_cache_features(&["example-answers"]). Core reads a[cache.<name>]table for each declared name as it reads its own[cache.robots-txt], and refuses a table whose name no linked module declares, naming the ones it could be, both ints config validateand when the service starts. A name is the module's own: a builder declaring core'srobots-txt, or a name another builder declares, is refused when the caches are resolved, so two vendors never share one cache and its keys without a word.LoadingCacheskeys its selections by name rather than by a fixed list, andCacheSettings::loading_cachesreturns core's own table first and the declared ones after it, in name order. A declared cache with no table, like a table naming no module (#19), takes the one loading cache module the build links, so a stock build holds a module's answers without a line in the document, and keeps nothing when the build links none or several.The seam probe declares
seam-probe-answersand offers a loading cache of its own, and the Axum adapter's seam tests prove from outside core that the table selects it, that a declared cache with no table takes the one module linked, and that a misspelt table is refused by the deploy check with the message startup gives.Why
A module that holds its own answers, one service answer that every page of a deployment asks for, asked core for the cache of the name it chose, found no table for it, and got the cache that holds nothing, so every request loaded the answer again. Measured on one deployment at six service calls per page request where one is needed, with a loading cache linked and nothing in the document able to say the module's cache existed, because core read a fixed list of names.
What breaks
Nothing in a deployment's documents.
CacheSettingsno longer rejects an unknown[cache.<name>]table when the document is parsed.ts config validaterefuses it instead, as the service does when it starts, if no linked module declares the name.The commits
robots-txtdeclaration is refused, the seam probe declares and offers a cache, and the guide names a fictional moduleCI passed on d9656fd, 19 of 19, and runs on 1133273.
What is not in this pull request
noneincluded, is refused when the service starts.