chore: adopt corepack and pnpm 11.5.2 in CI#44
Conversation
- Enable pnpm via corepack in all workflows (drop pnpm/action-setup) - Bump packageManager to pnpm@11.5.2 - Run CI on Node.js 22, 24, 26; bump checkout/setup-node to v6 - Use frozen-lockfile installs in CI and drop the stale node-20 guard - Expand pnpm-workspace.yaml with pnpm 11 supply-chain settings https://claude.ai/code/session_01FGXecDpeHMLiYmwa8Y9CD9
There was a problem hiding this comment.
Code Review
This pull request updates the pnpm package manager version in package.json and adds several supply-chain and build configuration settings to pnpm-workspace.yaml. However, a review comment points out that these configuration settings (such as minimumReleaseAge, strictDepBuilds, and blockExoticSubdeps) are invalid in pnpm-workspace.yaml and will be silently ignored; they should instead be configured in .npmrc or package.json.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 19 19
Branches 1 1
=========================================
Hits 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| node-version: 24 | ||
| cache: 'pnpm' | ||
|
|
||
| - name: Enable Corepack |
There was a problem hiding this comment.
you dont have to do corepack enable as pnpm/setup github action detects it for you. You should use that
There was a problem hiding this comment.
Done — switched all three workflows (tests, code-coverage, release) from corepack enable to pnpm/action-setup@v4, which picks up the pnpm version from the packageManager field. Also restored the cache: 'pnpm' step that pairs with it. Pushed in 2102ace.
Generated by Claude Code
pnpm/action-setup detects the pnpm version from the packageManager field, so the explicit corepack enable step is redundant. Restore the pnpm store cache that pairs with it. https://claude.ai/code/session_01FGXecDpeHMLiYmwa8Y9CD9
Summary
Upgrades the React SDK to use pnpm 11 via corepack, aligning the CI and workspace configuration with the canonical
hookifiedtemplate.Changes
Package manager
packageManagertopnpm@11.5.2(latest pnpm 11.x). Corepack reads this field as the single source of truth for the pnpm version.GitHub Actions (
tests,code-coverage,release)corepack enable) instead ofpnpm/action-setup.actions/checkoutandactions/setup-nodetov6(the recommended majors for the Node 24 runtime in 2026).cache: 'pnpm'fromsetup-node— it requires pnpm onPATHbefore corepack runs, so the corepack pattern enables it as a dedicated step instead.pnpm install --frozen-lockfileinstalls.testsmatrix runs on Node.js 22, 24, 26 and the staleif: matrix.node-version != '20'guard on the build step is removed.pnpm-workspace.yamlExpanded with pnpm 11 supply-chain settings:
esbuildis the only dependency that runs a build script, soallowBuildsstays minimal even withstrictDepBuilds: true.Note on
pnpm/action-setupThe task mentioned "use pnpm/setup". Since the goal is corepack (and
hookified, which this SDK extends, usescorepack enablerather thanpnpm/action-setup), this PR replacespnpm/action-setupwith corepack — the two are alternative mechanisms and corepack is the one driven by thepackageManagerfield. Happy to keeppnpm/action-setupinstead if that was the intent.Verification (local, pnpm 11.5.2 via corepack)
pnpm install --frozen-lockfile(clean, from-scratch) — passes; onlyesbuildbuilds.pnpm build— passes.pnpm test:ci— biome clean, 15 tests pass, 100% line coverage.https://claude.ai/code/session_01FGXecDpeHMLiYmwa8Y9CD9
Generated by Claude Code