Skip to content

chore: adopt corepack and pnpm 11.5.2 in CI#44

Merged
jaredwray merged 2 commits into
mainfrom
claude/nifty-sagan-lrcaru
Jun 9, 2026
Merged

chore: adopt corepack and pnpm 11.5.2 in CI#44
jaredwray merged 2 commits into
mainfrom
claude/nifty-sagan-lrcaru

Conversation

@jaredwray

Copy link
Copy Markdown
Contributor

Summary

Upgrades the React SDK to use pnpm 11 via corepack, aligning the CI and workspace configuration with the canonical hookified template.

Changes

Package manager

  • Bump packageManager to pnpm@11.5.2 (latest pnpm 11.x). Corepack reads this field as the single source of truth for the pnpm version.

GitHub Actions (tests, code-coverage, release)

  • Set up pnpm with corepack (corepack enable) instead of pnpm/action-setup.
  • Bump actions/checkout and actions/setup-node to v6 (the recommended majors for the Node 24 runtime in 2026).
  • Drop cache: 'pnpm' from setup-node — it requires pnpm on PATH before corepack runs, so the corepack pattern enables it as a dedicated step instead.
  • Use deterministic pnpm install --frozen-lockfile installs.
  • tests matrix runs on Node.js 22, 24, 26 and the stale if: matrix.node-version != '20' guard on the build step is removed.

pnpm-workspace.yaml

Expanded with pnpm 11 supply-chain settings:

minimumReleaseAge: 10080
minimumReleaseAgeStrict: true
minimumReleaseAgeIgnoreMissingTime: false
blockExoticSubdeps: true
strictDepBuilds: true
dangerouslyAllowAllBuilds: false

allowBuilds:
  esbuild: true

esbuild is the only dependency that runs a build script, so allowBuilds stays minimal even with strictDepBuilds: true.

Note on pnpm/action-setup

The task mentioned "use pnpm/setup". Since the goal is corepack (and hookified, which this SDK extends, uses corepack enable rather than pnpm/action-setup), this PR replaces pnpm/action-setup with corepack — the two are alternative mechanisms and corepack is the one driven by the packageManager field. Happy to keep pnpm/action-setup instead if that was the intent.

Verification (local, pnpm 11.5.2 via corepack)

  • pnpm install --frozen-lockfile (clean, from-scratch) — passes; only esbuild builds.
  • pnpm build — passes.
  • pnpm test:ci — biome clean, 15 tests pass, 100% line coverage.

https://claude.ai/code/session_01FGXecDpeHMLiYmwa8Y9CD9


Generated by Claude Code

- Enable pnpm via corepack in all workflows (drop pnpm/action-setup)
- Bump packageManager to pnpm@11.5.2
- Run CI on Node.js 22, 24, 26; bump checkout/setup-node to v6
- Use frozen-lockfile installs in CI and drop the stale node-20 guard
- Expand pnpm-workspace.yaml with pnpm 11 supply-chain settings

https://claude.ai/code/session_01FGXecDpeHMLiYmwa8Y9CD9

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pnpm package manager version in package.json and adds several supply-chain and build configuration settings to pnpm-workspace.yaml. However, a review comment points out that these configuration settings (such as minimumReleaseAge, strictDepBuilds, and blockExoticSubdeps) are invalid in pnpm-workspace.yaml and will be silently ignored; they should instead be configured in .npmrc or package.json.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pnpm-workspace.yaml
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2f819ea) to head (2102ace).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           19        19           
  Branches         1         1           
=========================================
  Hits            19        19           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .github/workflows/release.yaml Outdated
node-version: 24
cache: 'pnpm'

- name: Enable Corepack

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont have to do corepack enable as pnpm/setup github action detects it for you. You should use that

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — switched all three workflows (tests, code-coverage, release) from corepack enable to pnpm/action-setup@v4, which picks up the pnpm version from the packageManager field. Also restored the cache: 'pnpm' step that pairs with it. Pushed in 2102ace.


Generated by Claude Code

pnpm/action-setup detects the pnpm version from the packageManager
field, so the explicit corepack enable step is redundant. Restore the
pnpm store cache that pairs with it.

https://claude.ai/code/session_01FGXecDpeHMLiYmwa8Y9CD9
@jaredwray jaredwray merged commit 428b623 into main Jun 9, 2026
10 checks passed
@jaredwray jaredwray deleted the claude/nifty-sagan-lrcaru branch June 9, 2026 15:28
@jaredwray jaredwray mentioned this pull request Jun 9, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants