Update gem for rails 8 support#1
Merged
Merged
Conversation
* Update to rubocop 1.12.x for newer ruby support * fix: remove deprecated warnings from Bundler * fix: ruby warnings about MAGIC_COMMENTS already defined * fix: Gemfile.lock for integration tests Co-authored-by: Andy Allan <git@gravitystorm.co.uk> Co-authored-by: Cuong Tran <ctran@users.noreply.github.com>
Signed-off-by: Lovro Bikic <lovro.bikic@infinum.hr>
This adds annotation of check constraints with an option to disable/enable annotation. Most of the work done in this PR is based off of existing implementation for annotating indexes and foreign keys. Signed-off-by: Lovro Bikic <lovro.bikic@infinum.hr>
…does not exist. (ctran#849) Some tables may have a table_name_prefix but no indexes. Previous versions of the code would strip the prefix and look for indexes on the resulting table which likely would not exist. This causes DB errors, at least in MySQL. So now check if the new table exists first before trying to show its indexes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes were originally pulled from ctran#1047, who already did all the work. The original gem seems to be long-dead now, this is only a temporary fix.