fix(SDK-1276): recover from a failed calculate instead of stalling forever - #2700
Merged
Merged
Conversation
…rever hasSeenCalculatingRef was set true right before calling calculate, and only ever reset back to false by the polling effect -- which never starts when calculate itself fails (e.g. a 409 conflict from the platform, which payrollsCalculate has no specific handling for). That left the component stuck on the calculating spinner permanently, with neither runPayroll/calculated nor runPayroll/processingFailed ever firing. Reset the ref on that failure path too, symmetric with the two resets the polling effect already has.
krisxcrash
marked this pull request as ready for review
September 3, 2026 23:22
dmortal
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasSeenCalculatingRefwas set true right before calling calculate, and only ever reset by the polling effect -- which never starts when calculate itself fails (e.g. a 409 conflict, whichpayrollsCalculatehas no specific handling for)runPayroll/calculatednorrunPayroll/processingFailedever firingTest plan