Rename Event Definition wizard "Fields" tab to "Additional Details"#26355
Conversation
The Fields step has grown beyond event fields — it now hosts the Tags input (and will host MITRE / detection-chain info), so the "Fields" label no longer reflects what the tab contains. Rename the visible label, the internal STEP_KEYS entry, and the step's `step` query parameter value from `fields` to `additional-details`. The FieldsForm component and the underlying `fields` data on the event definition are left unchanged. Documented in UPGRADING.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
danotorrey
changed the title
danotorrey
requested review from
dennisoelkers,
kingzacko1,
linuspahl and
zeeklop
The changelog snippet linter requires at least one issue or pull request number per entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
rename pr-26355.toml to follow changelog naming conventions
There was a problem hiding this comment.
Thanks for catching this. Done in 5f9b017.
|
I'll leave this open until tomorrow for any remaining feedback, then will merge it. |
Old bookmarked links using ?step=fields now resolve to the renamed additional-details step instead of falling back to the default. Updates UPGRADING.md accordingly and adds unit tests for the normalizer. Also renames the changelog entry to pr-26355.toml per review. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
I also added backwards-compatibility support for the old Also added https://github.com/Graylog2/e2e-tests/pull/1666 to update e2e tests for this PR. |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kingzacko1 Are you able to take one more look at this with the latest changes? e2e now passing with linked e2e PR, CL renamed, and I added backwards-compatibility handling for the old URL field |
kingzacko1
left a comment
kingzacko1
left a comment
There was a problem hiding this comment.
LGTM with the latest! Thanks, Dan!
|
Thanks @kingzacko1! I forgot to request a review on the e2e test as well: https://github.com/Graylog2/e2e-tests/pull/1666 Can you review that side as well? Once that is good to go, I will merge both together since e2e's are now passing on this PR. |
|
@danotorrey approved! |
2 participants
Closes Graylog2/graylog-plugin-enterprise#14222
The Fields step on the Event Definition wizard has grown beyond Event Field — it now hosts the Tags input (and Mitre info). This PR renames the step to Additional Details.
Scope: the visible label, the internal
STEP_KEYSentry, and the step's?step=query-param value (fields→additional-details). TheFieldsFormcomponent and the underlyingfieldsdata on the event definition are unchanged.This also renames the
?step=fieldsURL parameter to?step=additional-details(/alerts/definitions/<id>/edit?step=fieldsto/alerts/definitions/<id>/edit?step=additional-details). For backwards compatibility, old bookmarked links using?step=fieldsstill resolve to the renamed step. AnUPGRADING.mdnote was added for anyone who has bookmarked it./jpd Graylog2/e2e-tests#1666
Assisted with Claude Code