Skip to content

Make associated_inputs metric extensible to plugin input types#26334

Open
AntonEbel wants to merge 9 commits into
masterfrom
streams_inputs_column_fix
Open

Make associated_inputs metric extensible to plugin input types#26334
AntonEbel wants to merge 9 commits into
masterfrom
streams_inputs_column_fix

Conversation

@AntonEbel

@AntonEbel AntonEbel commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

associated_inputs on streams only knew about the open-source inputs collection, so the IDs it returned could only resolve to regular input titles and were filtered with a single hard-coded inputs:read check. Plugin-contributed input kinds (e.g. forwarder inputs) had no way to plug their own resolution or permission check into the metric.

Approach

  • Introduce a pluggable InputType SPI for declaring an input kind's read permission and id-existence check. Each id is tagged with its type at compute time so per-user filtering on read is a pure Shiro check.
  • Add frontend plugin slots so each input type can supply its own title/detail fetcher and link builder; the stream UI merges them with the regular-input catalog.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

/prd Graylog2/graylog-plugin-enterprise#14472
/nocl

@AntonEbel AntonEbel linked an issue Jun 15, 2026 that may be closed by this pull request
@kodjo-anipah kodjo-anipah self-requested a review June 15, 2026 08:53

@kodjo-anipah kodjo-anipah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, LGTM bit awkward probably the best we can do right now without big refactoring

@ousmaneo ousmaneo requested a review from a team June 18, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Associated Inputs column cannot resolve forwarder input titles

4 participants