Make associated_inputs metric extensible to plugin input types#26334
Open
AntonEbel wants to merge 9 commits into
Open
Make associated_inputs metric extensible to plugin input types#26334AntonEbel wants to merge 9 commits into
AntonEbel wants to merge 9 commits into
Conversation
kodjo-anipah
approved these changes
Jun 16, 2026
kodjo-anipah
left a comment
Member
There was a problem hiding this comment.
Just one nit, LGTM bit awkward probably the best we can do right now without big refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
associated_inputson streams only knew about the open-sourceinputscollection, so the IDs it returned could only resolve to regular input titles and were filtered with a single hard-codedinputs:readcheck. Plugin-contributed input kinds (e.g. forwarder inputs) had no way to plug their own resolution or permission check into the metric.Approach
InputTypeSPI for declaring an input kind's read permission and id-existence check. Each id is tagged with its type at compute time so per-user filtering on read is a pure Shiro check.Types of changes
/prd Graylog2/graylog-plugin-enterprise#14472
/nocl