Make node preview no longer mutate the graph - #4588
TrueDoctor wants to merge 11 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 18 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
…view where the export was assumed
0eb146f to
9e94ced
Compare
There was a problem hiding this comment.
All reported issues were addressed across 7 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
…h ones take effect
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Confidence score: 3/5
- In
editor/src/node_graph_executor/runtime.rs,monitor_inspect_noderewrites only output-0 edges, so previews of non-primary outputs can bypass the inspection monitor and show incomplete or incorrect inspection results — splice the monitor into the output selected for preview.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="editor/src/node_graph_executor/runtime.rs">
<violation number="1" location="editor/src/node_graph_executor/runtime.rs:240">
P2: A preview on a non-primary output still bypasses the inspection monitor: `monitor_inspect_node` rewrites only output-0 edges and connects its monitor to output 0. Make the monitor splice capture the previewed output index too, so the Data panel can read that preview.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| // Previews first, so the monitor below is spliced into the graph as it will be evaluated. | ||
| // Inserting it first would leave the preview pointing at the raw node, routing the export | ||
| // around the monitor and leaving the Data panel with nothing to read. | ||
| apply_previews(&mut network, &previewed); |
There was a problem hiding this comment.
P2: A preview on a non-primary output still bypasses the inspection monitor: monitor_inspect_node rewrites only output-0 edges and connects its monitor to output 0. Make the monitor splice capture the previewed output index too, so the Data panel can read that preview.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At editor/src/node_graph_executor/runtime.rs, line 240:
<comment>A preview on a non-primary output still bypasses the inspection monitor: `monitor_inspect_node` rewrites only output-0 edges and connects its monitor to output 0. Make the monitor splice capture the previewed output index too, so the Data panel can read that preview.</comment>
<file context>
@@ -234,9 +234,13 @@ impl NodeRuntime {
+ // Previews first, so the monitor below is spliced into the graph as it will be evaluated.
+ // Inserting it first would leave the preview pointing at the raw node, routing the export
+ // around the monitor and leaving the Data panel with nothing to read.
+ apply_previews(&mut network, &previewed);
+
// Insert the monitor node to manage the inspection
</file context>
This branch was successfully deployed
1 participant
No description provided.