You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(LinkPreviewList): take the preview thumbnail from image_url or thumb_url - #3392
Fixes REACT-1298. The link preview card in the composer used title_link, the page's URL, as its image. The browser then tried to load a web page as an image.
🛠 Implementation details
LinkPreviewCard takes its thumbnail from image_url, then thumb_url. That is the same order the sent message's Card uses. A preview with neither shows no thumbnail.
New tests in LinkPreviewList.test.tsx cover all three cases. Each fails on the old code.
🎨 UI Changes
A preview whose page has an image shows that image. Before, it showed a broken image. A preview with no image now shows no thumbnail.
Summary by CodeRabbit
Bug Fixes
Link previews now display the provided image, falling back to the thumbnail. If neither is available, no thumbnail is shown.
…umb_url
LinkPreviewCard used title_link, the page URL, as the image source. It now
uses image_url, then thumb_url, the same order as the sent message's Card.
A preview with neither shows no thumbnail.
Refs REACT-1298
No actionable comments were generated in the recent review.
Walkthrough
Link preview cards now use image_url first and thumb_url as a fallback. They do not use title_link as an image source. Tests cover these source-selection cases.
Changes: Link preview image selection
Layer / File(s)
Summary
Image source selection and tests src/components/MessageComposer/LinkPreviewList.tsx, src/components/MessageComposer/__tests__/LinkPreviewList.test.tsx
LinkPreviewCard selects image_url, then thumb_url. Tests verify both choices and confirm that no thumbnail renders when only title_link is present.
GetStream/stream-chat-react#3365: Introduces a configurable composer preview set with a default link-preview item that uses LinkPreviewCard.
Merge Risk: Minimal · up to bd0c1
The link preview thumbnail fix is consistent with the intended behavior and is ready to merge.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: using image_url or thumb_url for LinkPreviewList thumbnails.
Description check
The description includes the goal, implementation details, UI impact, linked issue, and test coverage. The UI Changes section explains the behavior change; no screenshots are needed for this non-visua…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description includes the goal, implementation details, UI impact, linked issue, and test coverage. The UI Changes section explains the behavior change; no screenshots are needed for this non-visual bug fix.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.00%. Comparing base (10e2b66) to head (bd0c157). ⚠️ Report is 8 commits behind head on master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes REACT-1298. The link preview card in the composer used
title_link, the page's URL, as its image. The browser then tried to load a web page as an image.🛠 Implementation details
LinkPreviewCardtakes its thumbnail fromimage_url, thenthumb_url. That is the same order the sent message'sCarduses. A preview with neither shows no thumbnail.LinkPreviewList.test.tsxcover all three cases. Each fails on the old code.🎨 UI Changes
A preview whose page has an image shows that image. Before, it showed a broken image. A preview with no image now shows no thumbnail.
Summary by CodeRabbit