compose: Restore location sharing in the sample behind a feature flag#6517
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughAdds a ChangesLocation Sharing Feature Flag
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
andremion
left a comment
There was a problem hiding this comment.
Looks good.
I just left a NIT on remember(cid)
|



Goal
While working on the OpenAPI migration, I realized the demo location sharing feature was still unused (we removed it while testing the v7 redesign). I'm readding it behind a flag so it's easier to test location (which is what I needed to do for testing the app with generated DTOs).
Closes AND-1259
Implementation
isLocationSharingEnabledflag toCustomSettings(SharedPreferences, defaults tofalse) and a toggle for it on the login/settings screen.ChannelActivitynow passesLocationComponentFactorywhen the flag is on, and a no-op factory otherwise.Testing
Summary by CodeRabbit
New Features
Bug Fixes