Repository navigation
Preserve non-ASCII bytes when computing checksums and writing messages - #20
Merged
Merged
Conversation
GaryHughes
self-requested a review
September 22, 2026 11:35
Owner
|
Thanks for the fix @sgolev, there are a couple things that still need addressing but I'll merge and then make those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The checksum is computed incorrectly for any message containing non-ASCII bytes. Those messages fail validation, causing the session to desynchronize and eventually die.
A similar encoding issue exists for the message writer: non-ASCII data is lost.
Cause
The checksum should be the sum of the bytes on the wire, but
Field.ComputeCheckSum()re-encoded the value withEncoding.ASCII. That encoder is lossy: every byte above0x7Fis replaced with'?'(0x3F). Any message carrying non-ASCII data therefore fails validation.Fix
Use
Encoding.Latin1instead ofEncoding.ASCII. The former maps0x00-0xFFrange one-to-one and is the exact inverse to(char)result. It is identical to ASCII for0x00-0x7Frange, therefore nothing changes for ASCII-only sessions.