Spotless Rule

[Taskeren]

The current spotless rule will insert a return (\n) before the 3rd function call in a chained function call, like:

"Hello!".toString().toString().toString();

will be transformed to

"Hello!".toString()
    .toString()
    .toString()

This is very ugly in almost all situations.

This is nothing about the line length limit, as I've tested it.

[RenanOSX]

You can disable spotless if you don't like it on "gradle.properties" by uncommenting "disableSpotless = true"

[glektarssza]

@Taskeren What are you proposing as an alternative? What is the request here? I get you don't like the current behaviour, that's understandable (and I'm not a fan of it either) but then please propose an alternative. Simply saying "I don't like this" is not productive.

[Taskeren]

@Taskeren What are you proposing as an alternative? What is the request here? I get you don't like the current behaviour, that's understandable (and I'm not a fan of it either) but then please propose an alternative. Simply saying "I don't like this" is not productive.

I was just showing the problem here. But as you asked, I'd prefer one call per line with first call in the first like:

"FOO".doSomethingElse0()
    .doSomethingElse1()
    .doSomethingElse2()
    .doSomethingElse3();

And it should have such option to only make it multiple line when one line can't them all (exceeds the line limit).

And the problem is that it will always make it multiple line.

[Taskeren]

And I think it can be documented that how to customize our own rules (both spotless and style check or something) in a very simple explicit way.

[RuiXuqi]

I would be happy if the spotless configuration could be configured instead of being hard-coded and unmodifiable in com.gtnewhorizons.gtnhconvention.

[glektarssza]

Following back up on this (my life has been hectic the last bit due to losing my contract position);

And I think it can be documented that how to customize our own rules (both spotless and style check or something) in a very simple explicit way.

I agree, @Taskeren.

I would be happy if the spotless configuration could be configured instead of being hard-coded and unmodifiable in com.gtnewhorizons.gtnhconvention.

There is an unofficial way to do this I've discovered, @RuiXuqi. See my own mod, glektarssza/minecraft-gtnh-customizer. Specifically look at the spotless.gradle file which I use to customize the Spotless rules after disabling the built-in Spotless configuration. This is done by setting disableSpotless = true in your gradle.properties file. Not ideal but it is a valid workaround at the moment. You may also need to set gtnh.settings.blowdryerTag = LOCAL to prevent Blowdryer from snagging upstream settings from the example mod repository. Checkstyle has its own setting (disableCheckstyle = true).

I can document this methodology more clearly if this is an acceptable solution or, if there's still a desire for a greater degree of configurability, I can document it as an interim solution and look into implementing a better solution longer term.

[glektarssza]

@Taskeren Just following up on this.

Is the solution I provided above workable or would you prefer a solution more integrated into GTNHGradle?

[Taskeren]

@Taskeren Just following up on this.

Is the solution I provided above workable or would you prefer a solution more integrated into GTNHGradle?

I'd prefer to have a way in convention plugin instead of "rewriting" spotless stuff once again.
However, I've quitted NH modding for a while, so whatever.