Skip to content

ci: update code owners#4078

Merged
joshua-white merged 9 commits into
developfrom
ci/josh/code-owners-june-2026
Jun 11, 2026
Merged

ci: update code owners#4078
joshua-white merged 9 commits into
developfrom
ci/josh/code-owners-june-2026

Conversation

@joshua-white

Copy link
Copy Markdown
Contributor

Update codeowners list to ensure at least three owners for each file. Trying to balance having strict ownership vs no-ownership. Can make changes later if we run into poor review issues.

Also updating ACKNOWLEDGEMENTS and CODE_OF_CONDUCT to fix email and cited organizations.

@joshua-white joshua-white self-assigned this Jun 5, 2026
@joshua-white joshua-white added flag: ready for review type: CI Concerns github workflows or generic CI flag: no rebaseline Does not require rebaseline labels Jun 5, 2026
@joshua-white joshua-white added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Jun 6, 2026
@dkachuma

dkachuma commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

I feel that the current code owners file may be a bit too granular, especially given that we don't have a large number of active reviewers to support that level of detail. The fine-grained structure makes ownership harder to manage and slows down the review process.

Perhaps we could consider consolidating some of the code areas into broader categories. This might help simplify the file, make ownership clearer, and better align with the available reviewer capacity.

@rrsettgast

Copy link
Copy Markdown
Contributor

I feel that the current code owners file may be a bit too granular, especially given that we don't have a large number of active reviewers to support that level of detail. The fine-grained structure makes ownership harder to manage and slows down the review process.

Perhaps we could consider consolidating some of the code areas into broader categories. This might help simplify the file, make ownership clearer, and better align with the available reviewer capacity.

codeowners is inherently at directory level granularity. Lower levels override upper levels. So the only things that have extra granularity more than the component level is inputFiles, constitutive, and physicsSolvers. This makes some sense to have this level of granularity.

@joshua-white joshua-white merged commit 19df491 into develop Jun 11, 2026
22 checks passed
@joshua-white joshua-white deleted the ci/josh/code-owners-june-2026 branch June 11, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: CI Concerns github workflows or generic CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants