Skip to content

Move triaxial driver#4074

Merged
dkachuma merged 20 commits into
developfrom
dkachuma/triaxial-driver
Jun 12, 2026
Merged

Move triaxial driver#4074
dkachuma merged 20 commits into
developfrom
dkachuma/triaxial-driver

Conversation

@dkachuma

@dkachuma dkachuma commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Building on the constitutive testing infrastructure established in PR3883, this pull request transitions the TriaxialDriver to use the same framework.

  • Updates the driver to inherit from ConstitutiveDriver rather than directly from TaskBase.
  • Removes built-in unit testing and baseline comparison capabilities (baseline parameter and text comparison logic), delegating validation to the standard testing infrastructure.
  • Consolidates related XML input files into inputFiles/constitutiveDriver/ and adds new ATS integration tests for various triaxial models (e.g., Delft Egg, Drucker-Prager, Elastic Isotropic, Modified CamClay).
  • Updates the Sphinx documentation for the TriaxialDriver to reflect parameter changes, the removal of the integration testing section, and the new standardized output table format.
  • Removes the standalone testTriaxial C++ executable and legacy .txt baseline files, shifting fully to ATS-based restart and output checks.
  • Updates all tutorial examples using TriaxialDriver

@dkachuma dkachuma self-assigned this Jun 3, 2026
@dkachuma dkachuma added type: cleanup / refactor Non-functional change (NFC) ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests changes XML input ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Jun 3, 2026
@dkachuma dkachuma marked this pull request as ready for review June 3, 2026 19:17
@jhuang2601 jhuang2601 requested a review from castelletto1 as a code owner June 9, 2026 15:26

@jhuang2601 jhuang2601 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, thanks

@@ -1,19 +1,7 @@
# Specify list of tests

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this CMake file can be deleted, after #4040 is merged.

@dkachuma

dkachuma commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Nice change, thanks

Thanks for migrating the tutorial examples

@joshua-white joshua-white left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent to me. Nice upgrades.

@jhuang2601 jhuang2601 requested a review from bd713 as a code owner June 11, 2026 13:17

@jafranc jafranc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !!

Comment thread src/coreComponents/constitutiveDrivers/solid/TriaxialDriver.cpp
@dkachuma dkachuma merged commit ca139fb into develop Jun 12, 2026
22 checks passed
@dkachuma dkachuma deleted the dkachuma/triaxial-driver branch June 12, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes XML input ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: cleanup / refactor Non-functional change (NFC)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants