feat: Adding HDF5 support for tableFunction#3656
Open
castelletto1 wants to merge 33 commits into
Open
Conversation
Contributor
|
@castelletto1 Can you:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3656 +/- ##
===========================================
+ Coverage 57.56% 57.66% +0.10%
===========================================
Files 1235 1238 +3
Lines 106973 107363 +390
===========================================
+ Hits 61578 61911 +333
- Misses 45395 45452 +57 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
paveltomin
approved these changes
May 17, 2025
Contributor
|
@castelletto1 Can you provide the script or instruction for how to prepare the HDF5 tables (e.g., SPE10_layer84_permeability_porosity.hdf5 in this PR)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds HDF5 support to
tableFunction, addressing one issue raised in PR #3524.In addition to HDF5 support, a new function,
determineTableInputType, has been introduced to validate the input data fortableFunctionand ensure that only one type of input is provided in the xml file. The supported input types are:1D: One-dimensional data defined directly in the XML fileND: N-dimensional data provided via ASCII filesHDF5: N-dimensional data provided via an HDF5 fileThe
immiscibleTwoPhase_SPE10_layer84integrated test has been updated to demonstrate how to use the new HDF5 functionality. If approved, we plan to promote the use of HDF5 binary files over ASCII files wherever appropriate across all solvers.Note: Compressed HDF5 files are not supported at the moment. This limitation should be addressed as soon as possible to fully leverage HDF5 benefits.
Baseline updates are required: new XML children have been added:
hdf5CoordinateDatasetNames,hdf5File, andhdf5TableDatasetName.