Update to .NET 10 - #52
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the WinForms application project to target .NET 10, aligning with the intent to enable newer WinForms APIs such as Application.SetColorMode.
Changes:
- Updates the main
STROOPapplication target framework from .NET 8 Windows to .NET 10 Windows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c132c2e to
5e6edd9
Compare
|
Meant to put this as the summary comment of the review just now (oops): Also sorry for letting this PR rot for so long, I didn't feel much immediate pressure to merge this because #16 entails quite a few things beyond just the WinForms theme API or whatever, since there are a couple of custom controls that have hardcoded color values themselves (most notably the variable panels) that would need to be adjusted. So... yeah, looks good to me now 😪👍 |
|
: because #16 entails quite a few things beyond just the WinForms theme API or whatever, since there are a couple of custom controls that have hardcoded color values themselves I've started work on that already with no PR yet https://github.com/FramePerfection/STROOP/commits/dark-mode/ |
Rationale is that this will allow us to use the
Application.SetColorModeAPI to add back dark mode.That API exists since .NET 9, but 10 is an LTS release so might as well