Skip to content

Update to .NET 10 - #52

Merged
FramePerfection merged 4 commits into
Developmentfrom
net-10
Sep 4, 2026
Merged

Update to .NET 10#52
FramePerfection merged 4 commits into
Developmentfrom
net-10

Conversation

@abart27

@abart27 abart27 commented May 16, 2026

Copy link
Copy Markdown
Collaborator

Rationale is that this will allow us to use the Application.SetColorMode API to add back dark mode.

That API exists since .NET 9, but 10 is an LTS release so might as well

Copilot AI review requested due to automatic review settings May 16, 2026 06:08
@abart27 abart27 mentioned this pull request May 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WinForms application project to target .NET 10, aligning with the intent to enable newer WinForms APIs such as Application.SetColorMode.

Changes:

  • Updates the main STROOP application target framework from .NET 8 Windows to .NET 10 Windows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread STROOP/STROOP.csproj
@abart27 abart27 changed the title chore: update to .NET 10 Update to .NET 10 May 16, 2026
@abart27
abart27 requested a review from FramePerfection July 6, 2026 12:58
@abart27
abart27 requested review from FramePerfection and removed request for FramePerfection July 25, 2026 16:34
Comment thread STROOP/STROOP.csproj
Comment thread .github/workflows/build-debug.yml
@FramePerfection

Copy link
Copy Markdown
Owner

Meant to put this as the summary comment of the review just now (oops):
I've updated the readme because I don't like lying to people 😉

Also sorry for letting this PR rot for so long, I didn't feel much immediate pressure to merge this because #16 entails quite a few things beyond just the WinForms theme API or whatever, since there are a couple of custom controls that have hardcoded color values themselves (most notably the variable panels) that would need to be adjusted.
I've also considered how .NET 10 is not yet a suitable candidate for cross-platform support, as the Linux distros that I am familiar with lag behind quite a bit (the most popular ones are still at best at .NET 8 as far as I can tell), but given that Linux support is definitely a whole different can of worms, I've come to accept that that vague thought shouldn't be (even a mental) blocker for this.

So... yeah, looks good to me now 😪👍

@abart27

abart27 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

: because #16 entails quite a few things beyond just the WinForms theme API or whatever, since there are a couple of custom controls that have hardcoded color values themselves

I've started work on that already with no PR yet

https://github.com/FramePerfection/STROOP/commits/dark-mode/

@FramePerfection
FramePerfection merged commit 35540f6 into Development Sep 4, 2026
1 check passed
@FramePerfection
FramePerfection deleted the net-10 branch September 4, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants